Skip to content

Commit 8fcc3cb

Browse files
Merge branch 'feat/co-proposers-3677' into feat/proposals_briefs_collaborators_3700
2 parents 096eb53 + 6438bad commit 8fcc3cb

30 files changed

+611
-44
lines changed

.config/dictionaries/project.dic

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ collabs
7373
commitlog
7474
concatcp
7575
configureondemand
76+
coproposer
7677
coproposers
7778
COSE
7879
coti

catalyst_voices/apps/voices/lib/pages/proposal/widget/proposal_collaborators.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ class _Username extends StatelessWidget {
117117
spacing: 8,
118118
children: [
119119
Text(
120-
catalystId.username ?? context.l10n.anonymousUsername,
120+
catalystId.getDisplayName(context),
121121
style: Theme.of(context).textTheme.titleSmall?.copyWith(
122122
color: status.labelColor(context),
123123
),

catalyst_voices/apps/voices/lib/pages/proposal_builder/proposal_builder_page.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,7 @@ class _ProposalBuilderBodyState extends State<_ProposalBuilderBody>
335335
proposalTitle: signal.proposalTitle ?? context.l10n.proposalEditorStatusDropdownViewTitle,
336336
currentIteration: signal.currentIteration,
337337
nextIteration: signal.nextIteration,
338+
showCollaboratorsInfo: signal.hasCollaborators,
338339
) ??
339340
false;
340341

catalyst_voices/apps/voices/lib/pages/proposal_builder/proposal_builder_segments.dart

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import 'dart:async';
22

33
import 'package:catalyst_voices/common/ext/build_context_ext.dart';
4+
import 'package:catalyst_voices/pages/co_proposers/widgets/add_collaborator/add_collaborator_dialog.dart';
45
import 'package:catalyst_voices/pages/proposal_builder/tiles/proposal_builder_comment_tile.dart';
56
import 'package:catalyst_voices/widgets/comment/proposal_add_comment_tile.dart';
67
import 'package:catalyst_voices/widgets/comment/proposal_comments_header_tile.dart';
8+
import 'package:catalyst_voices/widgets/common/semantics/combine_semantics.dart';
79
import 'package:catalyst_voices/widgets/list/category_requirements_list.dart';
810
import 'package:catalyst_voices/widgets/modals/proposals/category_brief_dialog.dart';
911
import 'package:catalyst_voices/widgets/tiles/specialized/document_builder_section_tile_controller.dart';
@@ -18,16 +20,27 @@ import 'package:catalyst_voices_view_models/catalyst_voices_view_models.dart';
1820
import 'package:flutter/material.dart';
1921
import 'package:scrollable_positioned_list/scrollable_positioned_list.dart';
2022

21-
part 'proposal_builder_action_widgets.dart';
22-
part 'proposal_builder_document_widgets.dart';
23+
part 'widgets/proposal_builder_category_action.dart';
24+
part 'widgets/proposal_builder_collaborators_action.dart';
25+
part 'widgets/proposal_builder_document_category.dart';
26+
part 'widgets/proposal_builder_document_collaborators.dart';
2327

2428
final DocumentPropertyActionOverrides _widgetActionOverrides = {
25-
ProposalDocument.categoryDetailsNodeId: const _CategoryDetailsAction(),
29+
ProposalDocument.categoryDetailsNodeId: (_, _, _) => const _CategoryDetailsAction(),
30+
ProposalDocument.collaboratorsNodeId: (_, isEditMode, onEditableChanged) =>
31+
_CollaboratorsDetailsAction(
32+
isEditMode: isEditMode,
33+
onChanged: onEditableChanged,
34+
),
2635
};
2736

2837
final DocumentPropertyBuilderOverrides _widgetOverrides = {
29-
ProposalDocument.categoryDetailsNodeId: (context, property) =>
30-
_CategoryDetails(property: property),
38+
ProposalDocument.categoryDetailsNodeId: (_, property, _) => _CategoryDetails(property: property),
39+
ProposalDocument.collaboratorsNodeId: (_, _, collaboratorsSectionData) =>
40+
_CollaboratorsDetailsSelector(
41+
collaboratorsSectionData: collaboratorsSectionData,
42+
maxCollaborators: ProposalDocument.maxCollaboratorsPerProposal,
43+
),
3144
};
3245

3346
class ProposalBuilderSegmentsSelector extends StatelessWidget {
@@ -97,6 +110,10 @@ class _DocumentSection extends StatelessWidget {
97110
final event = SectionChangedEvent(changes: value);
98111
context.read<ProposalBuilderBloc>().add(event);
99112
},
113+
onCollaboratorsChanged: (collaborators) {
114+
final event = UpdateCollaboratorsEvent(collaborators: collaborators);
115+
context.read<ProposalBuilderBloc>().add(event);
116+
},
100117
actionOverrides: _widgetActionOverrides,
101118
overrides: _widgetOverrides,
102119
),

catalyst_voices/apps/voices/lib/pages/proposal_builder/proposal_builder_action_widgets.dart renamed to catalyst_voices/apps/voices/lib/pages/proposal_builder/widgets/proposal_builder_category_action.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
part of 'proposal_builder_segments.dart';
1+
part of '../proposal_builder_segments.dart';
22

33
class _CategoryDetailsAction extends StatelessWidget {
44
const _CategoryDetailsAction();
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
part of '../proposal_builder_segments.dart';
2+
3+
class _CollaboratorsDetailsAction extends StatelessWidget {
4+
final bool isEditMode;
5+
final ValueChanged<EditableTileChange> onChanged;
6+
7+
const _CollaboratorsDetailsAction({
8+
required this.isEditMode,
9+
required this.onChanged,
10+
});
11+
12+
@override
13+
Widget build(BuildContext context) {
14+
return CombineSemantics(
15+
identifier: 'EditableTileEditCancelButton',
16+
child: VoicesEditCancelButton(
17+
key: const Key('EditableTileEditCancelButton'),
18+
style: VoicesEditCancelButtonStyle.outlinedWithIcon,
19+
onTap: () {
20+
final change = (
21+
isEditMode: !isEditMode,
22+
source: EditableTileChangeSource.cancel,
23+
);
24+
onChanged(change);
25+
},
26+
isEditing: isEditMode,
27+
),
28+
);
29+
}
30+
}

catalyst_voices/apps/voices/lib/pages/proposal_builder/proposal_builder_document_widgets.dart renamed to catalyst_voices/apps/voices/lib/pages/proposal_builder/widgets/proposal_builder_document_category.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
part of 'proposal_builder_segments.dart';
1+
part of '../proposal_builder_segments.dart';
22

33
class _CategoryDetails extends StatelessWidget {
44
final DocumentProperty property;

0 commit comments

Comments
 (0)