chore: code review changes

Author: dt-iohk

catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/voting/voting_cubit.dart

@@ -224,10 +224,7 @@ final class VotingCubit extends Cubit<VotingState>
   }
 
   VotingPhaseProgressViewModel? _buildVotingPhase(Campaign? campaign) {
-    final campaignVotingPhase = campaign?.phaseStateTo(
-      CampaignPhaseType.communityVoting,
-      DateTimeExt.now(),
-    );
+    final campaignVotingPhase = campaign?.phaseStateTo(CampaignPhaseType.communityVoting);
     final campaignStartDate = campaign?.startDate;
 
     if (campaignVotingPhase != null && campaignStartDate != null) {

catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/voting_ballot/voting_ballot_bloc.dart

@@ -153,10 +153,7 @@ final class VotingBallotBloc extends Bloc<VotingBallotEvent, VotingBallotState>
   }
 
   VotingPhaseProgressViewModel? _buildVotingPhase(Campaign? campaign) {
-    final campaignVotingPhase = campaign?.phaseStateTo(
-      CampaignPhaseType.communityVoting,
-      DateTimeExt.now(),
-    );
+    final campaignVotingPhase = campaign?.phaseStateTo(CampaignPhaseType.communityVoting);
     final campaignStartDate = campaign?.startDate;
 
     if (campaignVotingPhase != null && campaignStartDate != null) {

catalyst_voices/packages/internal/catalyst_voices_models/lib/src/campaign/campaign.dart

@@ -100,10 +100,7 @@ Project Catalyst turns economic power into innovation power by using the Cardano
   }
 
   bool get isVotingStateActive {
-    return phaseStateTo(
-      CampaignPhaseType.communityVoting,
-      DateTimeExt.now(),
-    ).status.isActive;
+    return phaseStateTo(CampaignPhaseType.communityVoting).status.isActive;
   }
 
   @override
@@ -182,10 +179,13 @@ Project Catalyst turns economic power into innovation power by using the Cardano
     return categories.any((element) => element.id.id == id);
   }
 
-  /// Returns the state of the campaign for a specific phase at given [date].
+  /// Returns the state of the campaign for a specific phase at given [date], which defaults to
+  /// [DateTimeExt.now].
   /// It's a shortcut for [state] when you are only interested in a specific phase. And want to know
   /// the status of that phase.
-  CampaignPhaseState phaseStateTo(CampaignPhaseType type, DateTime date) {
+  CampaignPhaseState phaseStateTo(CampaignPhaseType type, [DateTime? date]) {
+    date ??= DateTimeExt.now();
+
     final phase = timeline.phases.firstWhere(
       (phase) => phase.type == type,
       orElse: () => throw StateError('Type $type not found'),

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/campaign/campaign_repository.dart

@@ -32,10 +32,7 @@ final class CampaignRepositoryImpl implements CampaignRepository {
 
   @override
   Future<List<Campaign>> getAllCampaigns() async {
-    return [
-      Campaign.f15(),
-      Campaign.f14(),
-    ];
+    return Campaign.all;
   }
 
   @override

catalyst_voices/packages/internal/catalyst_voices_services/lib/src/campaign/campaign_service.dart

@@ -199,10 +199,7 @@ final class CampaignServiceImpl implements CampaignService {
 
   Future<Campaign> _updateSubmissionCloseDate(Campaign campaign) async {
     final proposalSubmissionTime = campaign
-        .phaseStateTo(
-          CampaignPhaseType.proposalSubmission,
-          DateTimeExt.now(),
-        )
+        .phaseStateTo(CampaignPhaseType.proposalSubmission)
         .phase
         .timeline
         .to;