feat: Add STAC item id to geopandas #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to asottile-archive/seed-isort-config#72 (comment) this tool is no longer needed in isort >= 5.0.0. This tool caused a recent CI error. https://results.pre-commit.ci/run/github/170353835/1692198868.g00dNv-_TMu5Mbobo2_n4Q
Author
|
This is ready for review, @TomAugspurger , @scottyhq . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
to_geopandas()the resulting GeoDataFrame has noidcolumn indicating the STAC item id if it is not included in the STAC item properties. This small change checks if anidcolumn is present in the GeoDataFrame, and if not, adds the STAC item ids.Also fixes a CI build error caused by
seed-isort-config, which is no longer maintained and is obsoleted by isort >= 5.0.0 ( asottile-archive/seed-isort-config#72 (comment) ).Also fixes a few sphinx build errors.