fix(android): Adding keyboard insets handling #8236
+11
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theproducer
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
jcesarmobile and
markemer
markemer
approved these changes
Nov 14, 2025
tafelnl
reviewed
Nov 14, 2025
Comment on lines
+131
to
+134
| if (keyboardVisible) { | ||
| // Remove when https://issues.chromium.org/issues/457682720 is fixed | ||
| bottomInsets = imeInsets.bottom - bottomInsets; | ||
| } |
There was a problem hiding this comment.
I'm not sure if this is something that should be removed when that issue is fixed, as that would effectively break it again for users with an older webview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds insets handling for open keyboards, and removes the no longer needed
adjustMarginsForEdgeToEdgeconfig option.(Thanks to @tafelnl for the suggestions!)