Message chan not closed

liangping · emersion · commit de4b254f4d93 · 2020-11-07T15:55:32.000+01:00
diff --git a/responses/fetch.go b/responses/fetch.go
@@ -36,12 +36,12 @@ func (r *Fetch) Handle(resp imap.Resp) error {
 }
 
 func (r *Fetch) WriteTo(w *imap.Writer) error {
+	var err error
 	for msg := range r.Messages {
 		resp := imap.NewUntaggedResp([]interface{}{msg.SeqNum, imap.RawString(fetchName), msg.Format()})
-		if err := resp.WriteTo(w); err != nil {
-			return err
+		if err == nil {
+			err = resp.WriteTo(w)
 		}
 	}
-
-	return nil
+	return err
 }

Original file line number	Diff line number	Diff line change
`@@ -36,12 +36,12 @@ func (r *Fetch) Handle(resp imap.Resp) error {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`func (r Fetch) WriteTo(w imap.Writer) error {`
	`39`	`+ var err error`
`39`	`40`	`for msg := range r.Messages {`
`40`	`41`	`resp := imap.NewUntaggedResp([]interface{}{msg.SeqNum, imap.RawString(fetchName), msg.Format()})`
`41`		`- if err := resp.WriteTo(w); err != nil {`
`42`		`- return err`
	`42`	`+ if err == nil {`
	`43`	`+ err = resp.WriteTo(w)`
`43`	`44`	`}`
`44`	`45`	`}`
`45`		`-`
`46`		`- return nil`
	`46`	`+ return err`
`47`	`47`	`}`