fix(tests): if no crates changed, test all crates (#5202) (#5203)

Author: nmrshll

.config/nextest.toml

@@ -30,6 +30,7 @@ or test(test_good_snapshot)
 or test(test_insufficient_balance_will_retry_success)
 or test(test_byzantine_peer_handling)
 or test(test_json_rpc_spec)
+or test(cluster_test)
 '''
 
 [[profile.ci.overrides]]
@@ -57,6 +58,8 @@ or test(test_pay_iota_multiple_times)
 or test(test_stake)
 or test(test_stake_all)
 or test(test_fullnode_traffic_control_spam_delegated)
+or test(ensure_no_tombstone_fragmentation_in_stack_frame_after_flush)
+or test(ip6)
 '''
 
 [profile.simtestnightly]

.github/actions/diffs/action.yml

@@ -51,6 +51,7 @@ runs:
             - ".github/workflows/_external_rust_tests.yml"
             - ".github/workflows/_cargo_deny.yml"
             - "scripts/cargo_sort/cargo_sort.py"
+            - "scripts/ci_tests/rust_tests.sh"
             - "Cargo.toml"
             - "Cargo.lock"
             - ".config/nextest.toml"

scripts/ci_tests/rust_tests.sh

@@ -81,11 +81,11 @@ function mk_test_filterset() {
             FILTERSET="$FILTERSET $add_filter"
         fi
     done
-    # if filterset is sill empty here, it means no changed crates were detected, there are no crates to test
-    if [ -z "$FILTERSET" ]; then
-        echo "test_none"
-        return
-    fi
+
+    # if no crates were changed, we want to run all tests.
+    # because changes that trigger the workflow but which aren't explicitly in a crate can potentially affect the entire workspace
+    # returning an empty filterset does that
+
     echo "${FILTERSET}"
 }
 
@@ -105,11 +105,10 @@ function rust_crates() {
     # non-deterministic `test` job.
     export IOTA_SKIP_SIMTESTS=1
 
+    # if no crates were changed, we want to run all tests.
+    # because changes that trigger the workflow but which aren't explicitly in a crate can potentially affect the entire workspace
+    # mk_test_filterset returns an empty filterset in this case
     FILTERSET="$(mk_test_filterset)"
-    if [ "$FILTERSET" == "test_none" ]; then
-        echo "No changed crates detected. Skipping"
-        return
-    fi
 
     command="cargo nextest run --config-file .config/nextest.toml --profile ci $FILTERSET"
     echo "Running: $command"