Skip to content

Commit a0b68c2

Browse files
committed
9272/change AzureBlobClientFactory
1 parent f101ea8 commit a0b68c2

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

service/src/main/java/greencity/service/AzureBlobClientFactory.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,18 @@
33
import com.azure.storage.blob.BlobContainerClient;
44
import com.azure.storage.blob.BlobServiceClient;
55
import com.azure.storage.blob.BlobServiceClientBuilder;
6-
import org.springframework.beans.factory.annotation.Value;
6+
import greencity.properties.AzureProperties;
7+
import lombok.RequiredArgsConstructor;
78
import org.springframework.stereotype.Component;
89

910
@Component
11+
@RequiredArgsConstructor
1012
public class AzureBlobClientFactory {
11-
@Value("${azure.connection.string}")
12-
private String connectionString;
13-
@Value("${azure.container.name}")
14-
private String containerName;
13+
private final AzureProperties azureProperties;
1514

1615
public BlobContainerClient getContainerClient() {
1716
BlobServiceClient serviceClient = new BlobServiceClientBuilder()
18-
.connectionString(connectionString).buildClient();
19-
return serviceClient.getBlobContainerClient(containerName);
17+
.connectionString(azureProperties.getAzureConnectionString()).buildClient();
18+
return serviceClient.getBlobContainerClient(azureProperties.getAzureContainerName());
2019
}
2120
}

service/src/test/java/greencity/service/AzureBlobClientFactoryTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,25 @@
11
package greencity.service;
22

33
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
4+
import greencity.properties.AzureProperties;
45
import org.junit.jupiter.api.Test;
56
import org.junit.jupiter.api.extension.ExtendWith;
7+
import org.mockito.Mock;
8+
import static org.mockito.Mockito.when;
69
import org.mockito.junit.jupiter.MockitoExtension;
7-
import org.springframework.test.util.ReflectionTestUtils;
810

911
@ExtendWith(MockitoExtension.class)
1012
class AzureBlobClientFactoryTest {
13+
@Mock
14+
private AzureProperties azureProperties;
15+
1116
@Test
1217
void getContainerClient_doesNotThrow() {
13-
AzureBlobClientFactory factory = new AzureBlobClientFactory();
18+
AzureBlobClientFactory factory = new AzureBlobClientFactory(azureProperties);
1419

15-
ReflectionTestUtils.setField(factory, "connectionString",
20+
when(azureProperties.getAzureConnectionString()).thenReturn(
1621
"DefaultEndpointsProtocol=https;AccountName=fake;AccountKey=fakeKey;EndpointSuffix=core.windows.net");
17-
ReflectionTestUtils.setField(factory, "containerName", "test-container");
22+
when(azureProperties.getAzureContainerName()).thenReturn("test-container");
1823

1924
assertDoesNotThrow(factory::getContainerClient);
2025
}

0 commit comments

Comments
 (0)