Missing down Method in Migration delete-old-fields-in-cooperatives-and-add-new-ones #1136 (#1350)

* add down method to rollback cooperatives

* added tests for 20241220213859-delete-old-fields-in-cooperatives-and-add-new-ones.spec

* fixed errors and tests

* update packages

Author: danikua

migrations/20241220213859-delete-old-fields-in-cooperatives-and-add-new-ones.js

@@ -15,17 +15,14 @@ function transformSection(section) {
     }
 
     if (activity.resourceType) transformedResource.resourceType = activity.resourceType
-    if (activity.resource.availability) {
+    if (activity.resource?.availability) {
       transformedResource.availability = {
         status: activity.resource.availability.status,
         date: activity.resource.availability.date
       }
     }
 
-    if (activity.completionStatus) transformedResource.completionStatus = activity.completionStatus
-    else {
-      transformedResource.completionStatus = 'active'
-    }
+    transformedResource.completionStatus = activity.completionStatus || 'active'
 
     return transformedResource
   })
@@ -56,6 +53,11 @@ async function processSections(db, cooperation) {
 
 module.exports = {
   async up(db) {
+    await db
+      .collection('cooperation')
+      .aggregate([{ $match: {} }, { $out: 'cooperation_backup' }])
+      .toArray()
+
     const allUserIds = new Set(
       (
         await db
@@ -71,14 +73,12 @@ module.exports = {
         await db.collection('cooperation').deleteOne({ _id: cooperation._id })
       }
 
-      if (Array.isArray(cooperation.proficiencyLevel)) {
-        if (cooperation.proficiencyLevel.length > 0) {
-          const averageProficiencyLevelIndex = cooperation.proficiencyLevel.length / 2
-          const averageProficiencyLevel = cooperation.proficiencyLevel[Math.ceil(averageProficiencyLevelIndex)]
-          await db
-            .collection('cooperation')
-            .updateOne({ _id: cooperation._id }, { $set: { proficiencyLevel: averageProficiencyLevel } })
-        }
+      if (Array.isArray(cooperation.proficiencyLevel) && cooperation.proficiencyLevel.length > 0) {
+        const averageProficiencyLevelIndex = cooperation.proficiencyLevel.length / 2
+        const averageProficiencyLevel = cooperation.proficiencyLevel[Math.ceil(averageProficiencyLevelIndex)]
+        await db
+          .collection('cooperation')
+          .updateOne({ _id: cooperation._id }, { $set: { proficiencyLevel: averageProficiencyLevel } })
       }
 
       if (!cooperation.title) {
@@ -93,6 +93,7 @@ module.exports = {
       }
       await processSections(db, cooperation)
     }
+
     await db.collection('cooperation').updateMany(
       {
         $or: [{ category: { $exists: true } }, { subject: { $exists: true } }, { languages: { $exists: true } }]
@@ -117,6 +118,21 @@ module.exports = {
       }
     )
   },
-  down() {},
+
+  async down(db) {
+    const backupExists = await db.listCollections({ name: 'cooperation_backup' }).hasNext()
+    if (!backupExists) {
+      throw new Error("Backup 'cooperation_backup' not found. Rollback is not possible.")
+    }
+
+    await db.collection('cooperation').drop()
+
+    await db
+      .collection('cooperation_backup')
+      .aggregate([{ $match: {} }, { $out: 'cooperation' }])
+      .toArray()
+
+    await db.collection('cooperation_backup').drop()
+  },
   transformSection
 }

package-lock.json

@@ -257,4 +257,38 @@ describe('20241220213859-delete-old-fields-in-cooperatives-and-add-new-ones', ()
 
     expect(updatedCooperation.sections).toEqual([])
   })
+  test('down should restore the cooperation collection from backup if it exists', async () => {
+    const backupDoc = {
+      _id: new ObjectId(),
+      initiator: validCooperation.initiator,
+      receiver: validCooperation.receiver,
+      title: 'Restored from Backup',
+      proficiencyLevel: 'Advanced',
+      sections: [],
+      additionalInfo: 'Restored info'
+    }
+    await database.collection('cooperation_backup').insertOne(backupDoc)
+
+    await database.collection(cooperationCollection).drop()
+
+    await require('@root/migrations/20241220213859-delete-old-fields-in-cooperatives-and-add-new-ones').down(database)
+
+    const restoredDoc = await database.collection(cooperationCollection).findOne({ _id: backupDoc._id })
+    expect(restoredDoc).toBeDefined()
+    expect(restoredDoc.title).toBe('Restored from Backup')
+
+    const backupStillExists = await database.listCollections({ name: 'cooperation_backup' }).hasNext()
+    expect(backupStillExists).toBe(false)
+  })
+
+  test('down should throw an error if the backup does not exist', async () => {
+    const backupExists = await database.listCollections({ name: 'cooperation_backup' }).hasNext()
+    if (backupExists) {
+      await database.collection('cooperation_backup').drop()
+    }
+
+    await expect(
+      require('@root/migrations/20241220213859-delete-old-fields-in-cooperatives-and-add-new-ones').down(database)
+    ).rejects.toThrow("Backup 'cooperation_backup' not found. Rollback is not possible.")
+  })
 })