fixed comments

Author: ArtemHolikov

src/containers/my-cooperations/cooperation-notes/CooperationNotes.tsx

@@ -1,4 +1,4 @@
-import React, { useState, useCallback, useEffect } from 'react'
+import { useState, useCallback, useEffect } from 'react'
 import { useParams } from 'react-router-dom'
 import { useTranslation } from 'react-i18next'
 import Box from '@mui/material/Box'
@@ -22,8 +22,7 @@ import {
 import useSnackbarAlert from '~/hooks/use-snackbar-alert'
 import useQuery from '~/hooks/use-query'
 import useMutation from '~/hooks/use-mutation'
-
-type NoteAction = 'create' | 'delete' | 'update' | 'duplicate'
+import { noteActionMap, NoteAction } from './constant'
 
 const CooperationNotes: React.FC = () => {
   const { t } = useTranslation()
@@ -35,25 +34,12 @@ const CooperationNotes: React.FC = () => {
 
   const onSuccessResponse = useCallback(
     (noteAction: NoteAction) => {
-      let responseMessage = ''
+      const responseMessage = noteActionMap[noteAction]
 
       if (noteAction === 'create') {
-        responseMessage = 'cooperationsPage.modalMessages.successCreation'
         setOpen(false)
       }
 
-      if (noteAction === 'delete') {
-        responseMessage = 'cooperationsPage.modalMessages.successDeletion'
-      }
-
-      if (noteAction === 'update') {
-        responseMessage = 'cooperationsPage.modalMessages.successUpdating'
-      }
-
-      if (noteAction === 'duplicate') {
-        responseMessage = 'cooperationsPage.modalMessages.successDuplication'
-      }
-
       handleAlert({
         severity: snackbarVariants.success,
         message: responseMessage
@@ -124,16 +110,16 @@ const CooperationNotes: React.FC = () => {
     })
   }
 
-  const updateSelectedNote = (params: {
-    noteId: string
-    data: CreateOrUpdateNoteParams
-  }) => {
-    return CooperationNotesService.updateNote(
-      cooperationId,
-      params.noteId,
-      params.data
-    )
-  }
+  const updateSelectedNote = useCallback(
+    (params: { noteId: string; data: CreateOrUpdateNoteParams }) => {
+      return CooperationNotesService.updateNote(
+        cooperationId,
+        params.noteId,
+        params.data
+      )
+    },
+    [cooperationId]
+  )
 
   const { mutate: updateNote, isPending: updateNoteLoading } = useMutation({
     mutationFn: updateSelectedNote,
@@ -142,15 +128,18 @@ const CooperationNotes: React.FC = () => {
     onSuccess: () => onSuccessResponse('update')
   })
 
-  const duplicateNote = (noteId: string) => {
-    const note = notes?.find((item) => item._id === noteId)
+  const duplicateNote = useCallback(
+    (noteId: string) => {
+      const note = notes?.find((item) => item._id === noteId)
 
-    if (!note) {
-      throw new Error('Note with specified ID was not found')
-    }
+      if (!note) {
+        throw new Error('Note with specified ID was not found')
+      }
 
-    return CooperationNotesService.createNote(note, cooperationId)
-  }
+      return CooperationNotesService.createNote(note, cooperationId)
+    },
+    [cooperationId, notes]
+  )
 
   const { mutate: duplicateItem } = useMutation({
     mutationFn: duplicateNote,

src/containers/my-cooperations/cooperation-notes/constant.ts

@@ -0,0 +1,8 @@
+export type NoteAction = 'create' | 'delete' | 'update' | 'duplicate'
+
+export const noteActionMap: Record<NoteAction, string> = {
+  create: 'cooperationsPage.modalMessages.successCreation',
+  delete: 'cooperationsPage.modalMessages.successDeletion',
+  duplicate: 'cooperationsPage.modalMessages.successDuplication',
+  update: 'cooperationsPage.modalMessages.successUpdating'
+}

tests/unit/containers/my-cooperations/cooperation-notes/CooperationNotes.spec.jsx

@@ -58,11 +58,14 @@ const appMain = {
   appMain: { userRole: 'tutor', userId: mockNotesData[0].author._id }
 }
 
-const getCooperationUrl = `${URLs.cooperations.getById.replace(':id', cooperationId)}`
 const getNotesUrl = URLs.notes.get.replace(':id', cooperationId)
 const createNoteUrl = URLs.notes.create.replace(':id', cooperationId)
-const updateNoteUrl = `${getCooperationUrl}/notes/${mockNotesData[0]._id}`
-const deleteNoteUrl = `${getCooperationUrl}/notes/${mockUpdatedNotesData[0]._id}`
+const updateNoteUrl = URLs.notes.update
+  .replace(':id', cooperationId)
+  .replace(':noteId', mockNotesData[0]._id)
+const deleteNoteUrl = URLs.notes.delete
+  .replace(':id', cooperationId)
+  .replace(':noteId', mockUpdatedNotesData[0]._id)
 const duplicateNoteUrl = URLs.notes.create.replace(':id', cooperationId)
 
 const url = getFullUrl({