Add tests for glob file patterns

Author: Goldziher

src/cli/run/filter.rs

@@ -374,3 +374,24 @@ async fn collect_files_from_args(
 
     Ok(files)
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    fn glob_pattern(pattern: &str) -> FilePattern {
+        serde_yaml::from_str::<FilePattern>(&format!("glob: {pattern}"))
+            .expect("glob pattern should deserialize")
+    }
+
+    #[test]
+    fn filename_filter_supports_glob_include_and_exclude() {
+        let include = glob_pattern("src/**/*.rs");
+        let exclude = glob_pattern("src/**/ignored.rs");
+        let filter = FilenameFilter::new(Some(&include), Some(&exclude));
+
+        assert!(filter.filter(Path::new("src/lib/main.rs")));
+        assert!(!filter.filter(Path::new("src/lib/ignored.rs")));
+        assert!(!filter.filter(Path::new("tests/main.rs")));
+    }
+}

src/config.rs

@@ -1037,6 +1037,49 @@ mod tests {
         assert!(parsed.exclude.is_match("dist/app"));
     }
 
+    #[test]
+    fn file_patterns_expose_sources_and_display() {
+        let pattern: FilePattern = serde_yaml::from_str(indoc::indoc! {r"
+            glob:
+              - src/**/*.rs
+              - crates/**/src/**/*.rs
+        "})
+        .expect("glob list should parse");
+        assert_eq!(
+            pattern.sources(),
+            &[
+                "src/**/*.rs".to_string(),
+                "crates/**/src/**/*.rs".to_string()
+            ]
+        );
+        assert_eq!(
+            pattern.sources_display(),
+            "src/**/*.rs, crates/**/src/**/*.rs"
+        );
+        assert!(pattern.is_match("src/main.rs"));
+        assert!(pattern.is_match("crates/foo/src/lib.rs"));
+        assert!(!pattern.is_match("tests/main.rs"));
+    }
+
+    #[test]
+    fn reject_empty_glob_list() {
+        let err = serde_yaml::from_str::<FilePattern>("glob: []").expect_err("empty list should fail");
+        assert!(
+            err.to_string().contains("glob list cannot be empty"),
+            "unexpected error: {err}"
+        );
+    }
+
+    #[test]
+    fn invalid_glob_pattern_errors() {
+        let err = serde_yaml::from_str::<FilePattern>("glob: \"[\"").expect_err("invalid glob should fail");
+        let msg = err.to_string().to_lowercase();
+        assert!(
+            msg.contains("glob"),
+            "error should mention glob issues: {msg}"
+        );
+    }
+
     #[test]
     fn parse_repos() {
         // Local hook should not have `rev`

src/hooks/meta_hooks.rs

@@ -257,6 +257,7 @@ pub fn identity(_hook: &Hook, filenames: &[&Path]) -> (i32, Vec<u8>) {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use prek_consts::{ALT_CONFIG_FILE, CONFIG_FILE};
     use crate::config::SerdeRegex;
 
     fn regex_pattern(pattern: &str) -> FilePattern {
@@ -284,4 +285,22 @@ mod tests {
         let exclude = regex_pattern(r"^html/");
         assert!(excludes_any(&files, None, Some(&exclude)));
     }
+
+    #[test]
+    fn meta_hook_patterns_cover_config_files() {
+        let apply = MetaHook::from_id("check-hooks-apply").expect("known meta hook");
+        let apply_files = apply.0.options.files.as_ref().expect("files should be set");
+        assert!(apply_files.is_match(CONFIG_FILE));
+        assert!(apply_files.is_match(ALT_CONFIG_FILE));
+
+        let useless = MetaHook::from_id("check-useless-excludes").expect("known meta hook");
+        let useless_files = useless.0.options.files.as_ref().expect("files should be set");
+        assert!(useless_files.is_match(CONFIG_FILE));
+        assert!(useless_files.is_match(ALT_CONFIG_FILE));
+        assert!(!useless_files.sources().is_empty());
+
+        let identity = MetaHook::from_id("identity").expect("known meta hook");
+        assert!(identity.0.options.files.is_none());
+        assert_eq!(identity.0.options.verbose, Some(true));
+    }
 }