-
-
Notifications
You must be signed in to change notification settings - Fork 87
Prevent post-checkout deadlock when cloning repos
#1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 89.73% 89.72% -0.01%
==========================================
Files 78 78
Lines 14767 14773 +6
==========================================
+ Hits 13251 13255 +4
- Misses 1516 1518 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
post-checkout deadlock when cloning repos
📦 Cargo Bloat ComparisonBinary size change: +0.00% (16.7 MiB → 16.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
|
Thanks! I think the better fix is just to set the internal env var PREK_INTERNAL__SKIP_POST_CHECKOUT. |
I have a global
post-checkouthook installed. I think what is happening is when I install hooks in my repository,prekthen clones and checks out the hook repository. This checkout then triggers prek in the hook repository via the global post-checkout hook which then waits on the parent prek running in my repository to release (which it won't) and hangs indefinitely.Also, I think it's veryyy rare anyone would want to run hooks here and for the most part, people don't want the install to error because the upstream hooks fail. Also, they (imo) needlessly slow this initialization anyways.
I confirmed locally this avoids the hanging.
Relevant logs from the issue,