Skip to content

Commit 22b0b0e

Browse files
authored
Delete v1/memory storage implementaiton (#7711)
Signed-off-by: Yuri Shkuro <[email protected]>
1 parent 2ef635f commit 22b0b0e

File tree

29 files changed

+73
-978
lines changed

29 files changed

+73
-978
lines changed

cmd/internal/storageconfig/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ import (
1818
"github.com/jaegertracing/jaeger/internal/storage/v1/badger"
1919
"github.com/jaegertracing/jaeger/internal/storage/v1/cassandra"
2020
es "github.com/jaegertracing/jaeger/internal/storage/v1/elasticsearch"
21-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
2221
"github.com/jaegertracing/jaeger/internal/storage/v2/clickhouse"
2322
"github.com/jaegertracing/jaeger/internal/storage/v2/grpc"
23+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
2424
)
2525

2626
var (

cmd/internal/storageconfig/config_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
"github.com/stretchr/testify/require"
1111
"go.opentelemetry.io/collector/confmap"
1212

13-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
13+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
1414
)
1515

1616
func TestConfigValidate(t *testing.T) {

cmd/internal/storageconfig/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ import (
2323
escfg "github.com/jaegertracing/jaeger/internal/storage/elasticsearch/config"
2424
"github.com/jaegertracing/jaeger/internal/storage/v1/badger"
2525
"github.com/jaegertracing/jaeger/internal/storage/v1/cassandra"
26-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
2726
"github.com/jaegertracing/jaeger/internal/storage/v2/clickhouse"
2827
"github.com/jaegertracing/jaeger/internal/storage/v2/clickhouse/clickhousetest"
2928
"github.com/jaegertracing/jaeger/internal/storage/v2/grpc"
29+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
3030
"github.com/jaegertracing/jaeger/internal/telemetry"
3131
)
3232

cmd/jaeger/internal/exporters/storageexporter/exporter_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ import (
2323
"github.com/jaegertracing/jaeger/cmd/jaeger/internal/extension/jaegerstorage"
2424
"github.com/jaegertracing/jaeger/internal/jiter"
2525
"github.com/jaegertracing/jaeger/internal/storage/v1"
26-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
2726
factorymocks "github.com/jaegertracing/jaeger/internal/storage/v1/mocks"
2827
"github.com/jaegertracing/jaeger/internal/storage/v2/api/tracestore"
2928
tracestoremocks "github.com/jaegertracing/jaeger/internal/storage/v2/api/tracestore/mocks"
29+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
3030
"github.com/jaegertracing/jaeger/internal/telemetry/otelsemconv"
3131
)
3232

cmd/jaeger/internal/extension/jaegerstorage/extension_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ import (
2929
"github.com/jaegertracing/jaeger/internal/storage/v1/api/metricstore"
3030
"github.com/jaegertracing/jaeger/internal/storage/v1/badger"
3131
"github.com/jaegertracing/jaeger/internal/storage/v1/cassandra"
32-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
3332
"github.com/jaegertracing/jaeger/internal/storage/v2/api/tracestore"
3433
"github.com/jaegertracing/jaeger/internal/storage/v2/clickhouse"
3534
"github.com/jaegertracing/jaeger/internal/storage/v2/clickhouse/clickhousetest"
3635
"github.com/jaegertracing/jaeger/internal/storage/v2/grpc"
36+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
3737
)
3838

3939
type errorFactory struct {

cmd/jaeger/internal/extension/remotesampling/extension_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ import (
3535
"github.com/jaegertracing/jaeger/cmd/internal/storageconfig"
3636
"github.com/jaegertracing/jaeger/cmd/jaeger/internal/extension/jaegerstorage"
3737
"github.com/jaegertracing/jaeger/internal/sampling/samplingstrategy/adaptive"
38-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
38+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
3939
)
4040

4141
func makeStorageExtension(t *testing.T, memstoreName string) component.Host {

cmd/jaeger/internal/processors/adaptivesampling/processor_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"github.com/jaegertracing/jaeger/cmd/jaeger/internal/extension/jaegerstorage"
2424
"github.com/jaegertracing/jaeger/cmd/jaeger/internal/extension/remotesampling"
2525
"github.com/jaegertracing/jaeger/internal/sampling/samplingstrategy/adaptive"
26-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
26+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
2727
)
2828

2929
func makeStorageExtension(t *testing.T, memstoreName string) component.Host {

cmd/remote-storage/app/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
"go.opentelemetry.io/collector/config/confignet"
1212

1313
"github.com/jaegertracing/jaeger/cmd/internal/storageconfig"
14-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
14+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
1515
"github.com/jaegertracing/jaeger/internal/tenancy"
1616
)
1717

internal/storage/integration/memstore_test.go

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ package integration
77
import (
88
"testing"
99

10+
"github.com/stretchr/testify/require"
1011
"go.uber.org/zap"
1112

12-
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
13-
"github.com/jaegertracing/jaeger/internal/storage/v2/v1adapter"
13+
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
14+
"github.com/jaegertracing/jaeger/internal/telemetry"
1415
"github.com/jaegertracing/jaeger/internal/testutils"
1516
)
1617

@@ -19,13 +20,21 @@ type MemStorageIntegrationTestSuite struct {
1920
logger *zap.Logger
2021
}
2122

22-
func (s *MemStorageIntegrationTestSuite) initialize(_ *testing.T) {
23+
func (s *MemStorageIntegrationTestSuite) initialize(t *testing.T) {
2324
s.logger, _ = testutils.NewLogger()
25+
telset := telemetry.NoopSettings()
26+
telset.Logger = s.logger
27+
28+
f, err := memory.NewFactory(memory.Configuration{MaxTraces: 10000}, telset)
29+
require.NoError(t, err)
30+
traceReader, err := f.CreateTraceReader()
31+
require.NoError(t, err)
32+
traceWriter, err := f.CreateTraceWriter()
33+
require.NoError(t, err)
2434

25-
store := memory.NewStore()
2635
s.SamplingStore = memory.NewSamplingStore(2)
27-
s.TraceReader = v1adapter.NewTraceReader(store)
28-
s.TraceWriter = v1adapter.NewTraceWriter(store)
36+
s.TraceReader = traceReader
37+
s.TraceWriter = traceWriter
2938

3039
// TODO DependencyWriter is not implemented in memory store
3140

internal/storage/integration/remote_memory_storage.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919

2020
"github.com/jaegertracing/jaeger/cmd/remote-storage/app"
2121
"github.com/jaegertracing/jaeger/internal/healthcheck"
22-
memv1 "github.com/jaegertracing/jaeger/internal/storage/v1/memory"
2322
"github.com/jaegertracing/jaeger/internal/storage/v2/memory"
2423
"github.com/jaegertracing/jaeger/internal/telemetry"
2524
"github.com/jaegertracing/jaeger/internal/tenancy"
@@ -48,7 +47,7 @@ func StartNewRemoteMemoryStorage(t *testing.T, port int) *RemoteMemoryStorage {
4847
telset.ReportStatus = telemetry.HCAdapter(healthcheck.New())
4948

5049
traceFactory, err := memory.NewFactory(
51-
memv1.Configuration{
50+
memory.Configuration{
5251
MaxTraces: 10000,
5352
},
5453
telset,

0 commit comments

Comments
 (0)