Duplicate occurrence of plugin directories in the local cache

[CodexRaunak]

Plugin Modernizer version

plugin modernizer 999999-SNAPSHOT (2025-08-27T15:06:59Z)

What Operating System are you using

Windows 10

Reproduction steps

Check your local cache

Upon checking, in one of the directories, the plugins have their src code and the other one has the logs in it, which is not desirable.

Expected Results

No duplicacy and only a single directory containing the src code directory and the logs.

[PratikMane0112]

@CodexRaunak, I run cli tool for skip-notifications-trait plugin with FetchMetaData recipe, using my personal gh-token .

whole cli command java -jar plugin-modernizer-cli\target\jenkins-plugin-modernizer-999999-SNAPSHOT.jar dry-run --plugins "skip-notifications-trait" --recipe "FetchMetadata"

but logs & src are fetched in one directory:

.cache\jenkins-plugin-modernizer-cli -

.cache\jenkins-plugin-modernizer-cli\skip-notifications-trait -

[PratikMane0112]

@CodexRaunak @jonesbusy @gounthar, Did I'm making mistake to understand the issue ?

[CodexRaunak]

@CodexRaunak @jonesbusy @gounthar, Did I'm making mistake to understand the issue ?

hey Pratik,
That's the required behaviour we need, the logs and the source directory should be within the plugin directory.
Can u check if that's the same thing for any other plugin? As when I tried to produce it, some plugins were having duplicate directories.

Thanks

[PratikMane0112]

@CodexRaunak @jonesbusy @gounthar, Did I'm making mistake to understand the issue ?

hey Pratik, That's the required behaviour we need, the logs and the source directory should be within the plugin directory. Can u check if that's the same thing for any other plugin? As when I tried to produce it, some plugins were having duplicate directories.

Thanks

Sure, Thanks

[PratikMane0112]

Hey @CodexRaunak, I tried to duplicate the issue for build-timeout, jobcacher & login-theme plugins by dry-running FetchMetadata, AddCodeOwner, SetupGitIgnore & SetupDependabot recipes but still the source & logs were in same directory as mentioned here.

I think issue occurs when we explicitely try a plugin name that doesn't exist in update center (like skip-notifications-trait-plugin).
So, I try explicitly "java -jar plugin-modernizer-cli\target\jenkins-plugin-modernizer-999999-SNAPSHOT.jar dry-run --plugins "login-theme-plugin" --recipe "FetchMetadata" was able to duplicate the issue

logs -

************* 
Plugin: login-theme-plugin
Error: Plugin not found in update center
Error: Failed to collect modernization metadata for plugin login-theme-plugin
*************

.cache -

In which login-theme dir contains source & logs as expected and login-theme-plugin dir contains only logs

[CodexRaunak]

I think issue occurs when we explicitely try a plugin name that doesn't exist in update center (like skip-notifications-trait-plugin). So, I try explicitly "java -jar plugin-modernizer-cli\target\jenkins-plugin-modernizer-999999-SNAPSHOT.jar dry-run --plugins "login-theme-plugin" --recipe "FetchMetadata" was able to duplicate the issue

That's a good progress, is that issue also reproducible when we have a local plugin?

Perhaps any mismatch between actual names of the plugin repository and what is in the update centrer? Check how these directories are created, Plugin.java.

[PratikMane0112]

That's a good progress, is that issue also reproducible when we have a local plugin?

Yes, issue is also reproducible when we have a plugin already fetched locally

Perhaps any mismatch between actual names of the plugin repository and what is in the update centrer? Check how these directories are created, Plugin.java.

after working of getLocalRepository() method & getPluginsDirectory the final path becomes: {cachePath}/{pluginName}/sources

So, when plugin name mismatch creates dir: cache/login-theme-plugin/ and tries to process but fails early (before creating sources) and only creates the logs dir for error logging

when there is correct plugin name, it creates dir: cache/login-theme/ and successfully processes and creates both sources and logs

And hence the two dir with diff results exists