Use Encoding.UTF8 singleton instead of re-creating every time

alex-jitbit · alex-jitbit · commit 03dc2635d0d4 · 2025-10-26T19:37:49.000+02:00
diff --git a/AspNetSaml/Saml.cs b/AspNetSaml/Saml.cs
@@ -63,8 +63,7 @@ private static string EnsureCertFormat(string cert)
 
 		public void LoadXmlFromBase64(string response)
 		{
-			UTF8Encoding enc = new UTF8Encoding();
-			LoadXml(enc.GetString(Convert.FromBase64String(response)));
+			LoadXml(Encoding.UTF8.GetString(Convert.FromBase64String(response)));
 		}
 
 		//an XML signature can "cover" not the whole document, but only a part of it

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,7 @@ private static string EnsureCertFormat(string cert)`
`63`	`63`
`64`	`64`	`public void LoadXmlFromBase64(string response)`
`65`	`65`	`{`
`66`		`- UTF8Encoding enc = new UTF8Encoding();`
`67`		`- LoadXml(enc.GetString(Convert.FromBase64String(response)));`
	`66`	`+ LoadXml(Encoding.UTF8.GetString(Convert.FromBase64String(response)));`
`68`	`67`	`}`
`69`	`68`
`70`	`69`	`//an XML signature can "cover" not the whole document, but only a part of it`