Enums containing digits are generated with unnecessary underscores

[quandor]

If Enum members contain a digit, the generated model contains an unnecessary underscore ('_') in front of the digit, if the java model is generated. While I do understand that a leading digit is not allowed in Enum members, I do not think digits at other locations in the name strictly need this prefix. Other tools behave differently as well.
See example below:

Schema:

{
  "$schema": "http://json-schema.org/draft-04/schema#",

  "properties": {
    "Android": {
      "enum": [
        "R2D2",
        "C3PO"
      ]
    }
  },
  "type": "object"
}

Generated model:

// This is not the complete model. Uninteresting parts are left out for brevity.
@Generated("jsonschema2pojo")
public enum Android {
        R_2_D_2("R2D2"),
        C_3_PO("C3PO");
}

Expected model:

// This is not the complete model. Uninteresting parts are left out for brevity.
@Generated("jsonschema2pojo")
public enum Android {
        R2D2("R2D2"),
        C3PO("C3PO");
}

[unkish]

Hi

If Enum members contain a digit, the generated model contains an unnecessary underscore ('_') in front of the digit, if the java model is generated. While I do understand that a leading digit is not allowed in Enum members, I do not think digits at other locations in the name strictly need this prefix. Other tools behave differently as well.

• Whilst it is understandable that enum constants brough up in example are valid, the logic behind generating constant names when building enum without extension is more complicated than just being a java identifier validator
• Different tools may or may not behave similarly
• Changing current behavior would mean making a rather undesirable backwards incompatible change

To generate expected model consider using javaEnums:

{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "properties": {
    "Android": {
      "enum": [
        "R2D2",
        "C3PO"
      ],
      "javaEnums": [
        {
          "name": "R2D2"
        },
        {
          "name": "C3PO"
        }
      ]
    }
  },
  "type": "object"
}

which would generate

// This is not the complete model. Uninteresting parts are left out for brevity.
@Generated("jsonschema2pojo")
public enum Android {

    R2D2("R2D2"),
    C3PO("C3PO");
}