Implement semantic tokens (for highlighting)#1186
Conversation
|
that's weird... I thought I added the last can we trigger CI for this again? |
leave it for the next implementation / separate PR
this line looks off in my editor
|
I would love to use this feature. Is there anyway to assist in the development? |
|
the skeleton is there and it works, although it needs to be polished. Namely, the column-row indices seem to be off, but I haven't had time to pin the bug: I can see some coloring that has the row-col off, but I'm having trouble reproducing them as a minimum working example for unit tests. The bugfix should be easy, probably just a If you've setup your IDE manually (neovim, emacs... anything but VSCode), then it should be fairly easy to point to this code and try it out: one thing that can also be worked on is adding matching cases to I'd recommend using tests for working on |
|
@FelipeLema was this functionality completed elsewhere? |
|
@caleb-allen "semantic tokens for julia language server"? not that I know of |
|
@FelipeLema what was the reason for closing this PR? |
|
@caleb-allen I don't see myself finishing it in the near future. I tried squeezing some time the last few weeks, but no dice. |
|
@FelipeLema I'm interested in picking up where you left off, however I hit a 404 when I try to access the repo you linked above https://github.com/FelipeLema/LanguageServer.jl Are you willing to share your latest work so that I could potentially pick it up? |
|
oh, I deleted that repo recently (that probably auto-closed this PR) I've re-uploaded the |
|
@FelipeLema I see. Thanks for re-uploading it! |
Fixes #847
pick up from #961
For every PR, please check the following: