Revert "test: Use XCTestExpectation in SDKInternalTests (getsentry#5828)"

This reverts commit d88a5e4.

Author: philipsawyerdd

Tests/SentryTests/SentrySDKInternalTests.swift

@@ -716,6 +716,7 @@ class SentrySDKInternalTests: XCTestCase {
         let runtimeInitSystemTimestamp = SentryDependencyContainer.sharedInstance().dateProvider.date()
 
         func setAppStartMeasurement(_ queue: DispatchQueue, _ i: Int) {
+            group.enter()
             queue.async {
                 let appStartTimestamp = SentryDependencyContainer.sharedInstance().dateProvider.date().addingTimeInterval(TimeInterval(i))
                 let appStartMeasurement = TestData.getAppStartMeasurement(
@@ -724,8 +725,7 @@ class SentrySDKInternalTests: XCTestCase {
                     runtimeInitSystemTimestamp: UInt64(runtimeInitSystemTimestamp.timeIntervalSince1970)
                 )
                 SentrySDKInternal.setAppStartMeasurement(appStartMeasurement)
-
-                expectation.fulfill()
+                group.leave()
             }
         }
 
@@ -735,24 +735,20 @@ class SentrySDKInternalTests: XCTestCase {
 
         let queue1 = createQueue()
         let queue2 = createQueue()
+        let group = DispatchGroup()
 
         let amount = 100
 
-        let expectation = XCTestExpectation(description: "Wait for all measurements to be set")
-        expectation.expectedFulfillmentCount = amount * 2
-        expectation.assertForOverFulfill = true
-
-        for i in 0..<amount {
+        for i in 0...amount {
             setAppStartMeasurement(queue1, i)
             setAppStartMeasurement(queue2, i)
         }
 
         queue1.activate()
         queue2.activate()
+        group.waitWithTimeout(timeout: 100)
 
-        wait(for: [expectation], timeout: 10.0)
-
-        let timestamp = SentryDependencyContainer.sharedInstance().dateProvider.date().addingTimeInterval(TimeInterval(amount - 1))
+        let timestamp = SentryDependencyContainer.sharedInstance().dateProvider.date().addingTimeInterval(TimeInterval(amount))
         XCTAssertEqual(timestamp, SentrySDKInternal.getAppStartMeasurement()?.appStartTimestamp)
     }