fix sed inplace for macos

Signed-off-by: apedriza <[email protected]>

Author: apedriza

internal/controller/k0smotron.io/k0smotroncluster_entrypoint.go

@@ -42,6 +42,7 @@ func (scope *kmcScope) generateEntrypointCM(kmc *km.Cluster) (v1.ConfigMap, erro
 		"KineDataSourceURLPlaceholder": kineDataSourceURLPlaceholder,
 		"K0sControllerArgs":            getControllerFlags(kmc),
 		"PrivilegedPortIsUsed":         kmc.Spec.Service.APIPort <= 1024,
+		"UniversalSedInplace":          universalSedInplace,
 	})
 	if err != nil {
 		return v1.ConfigMap{}, err
@@ -106,15 +107,19 @@ func getControllerFlags(kmc *km.Cluster) string {
 	return strings.Join(flags, " ")
 }
 
-const entrypointTemplate = `
+const (
+	entrypointTemplate = `
 #!/bin/sh
 
+# Universal in-place "sedi" function for sed
+{{ .UniversalSedInplace }}
+
 # Put the k0s.yaml in place
 mkdir /etc/k0s && echo "$K0SMOTRON_K0S_YAML" > /etc/k0s/k0s.yaml
 
 # Substitute the kine datasource URL from the env var
 escaped_url=$(printf '%s' "$K0SMOTRON_KINE_DATASOURCE_URL" | sed 's/[&/\]/\\&/g')
-sed -i "s {{ .KineDataSourceURLPlaceholder }} $escaped_url g" /etc/k0s/k0s.yaml
+sedi "s|{{ .KineDataSourceURLPlaceholder }}|$escaped_url|g" /etc/k0s/k0s.yaml
 
 {{if .PrivilegedPortIsUsed}}
 apk add --no-cache libcap
@@ -124,3 +129,15 @@ apk add --no-cache libcap
 # Run the k0s controller
 k0s controller {{ .K0sControllerArgs }}
 `
+	universalSedInplace = `
+sedi() {
+    # Try GNU sed
+    if sed --version >/dev/null 2>&1; then
+        sed -i "$@"
+    else
+        # BSD sed (macOS) or BusyBox sed
+        sed -i '' "$@"
+    fi
+}
+`
+)

internal/controller/k0smotron.io/k0smotroncluster_entrypoint_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package k0smotronio
 
 import (
+	"fmt"
 	"os"
 	"os/exec"
 	"strings"
@@ -139,12 +140,12 @@ func TestKineDataSourceURLSubstitution(t *testing.T) {
 				if strings.Contains(line, "escaped_url=$(printf") && strings.Contains(line, "K0SMOTRON_KINE_DATASOURCE_URL") {
 					printfLine = line
 				}
-				if strings.Contains(line, "sed -i") && strings.Contains(line, "$escaped_url") {
+				if strings.Contains(line, "sedi") && strings.Contains(line, "$escaped_url") {
 					sedLine = line
 				}
 			}
 			require.NotEmpty(t, printfLine, "printf command not found in entrypoint script")
-			require.NotEmpty(t, sedLine, "sed command not found in entrypoint script")
+			require.NotEmpty(t, sedLine, "sedi command not found in entrypoint script")
 
 			testK0sConfig := `apiVersion: k0s.k0sproject.io/v1beta1
 kind: ClusterConfig
@@ -169,10 +170,11 @@ spec:
 			os.Setenv("K0SMOTRON_KINE_DATASOURCE_URL", tc.kineDataSourceURL)
 			t.Cleanup(func() { os.Unsetenv("K0SMOTRON_KINE_DATASOURCE_URL") })
 
-			actualSedCmd := strings.Replace(sedLine, "/etc/k0s/k0s.yaml", tmpFile.Name(), 1)
+			actualSediCmd := strings.Replace(sedLine, "/etc/k0s/k0s.yaml", tmpFile.Name(), 1)
 
-			combinedScript := printfLine + "\n" + actualSedCmd
+			combinedScript := universalSedInplace + "\n" + printfLine + "\n" + actualSediCmd
 
+			fmt.Println(combinedScript)
 			cmd := exec.Command("sh", "-c", combinedScript)
 			cmd.Env = append(os.Environ(), "K0SMOTRON_KINE_DATASOURCE_URL="+tc.kineDataSourceURL)