chore: add hadolint action

add hadolint check action

Signed-off-by: adrianc <[email protected]>

Author: adrianchiris

.github/workflows/test.yml

@@ -116,6 +116,24 @@ jobs:
         with:
           severity: error
 
+  hadolint:
+    name: hadolint
+    runs-on: ubuntu-24.04
+    steps:
+    - name: checkout PR 
+      uses: actions/checkout@v5
+    - name: run hadolint on operator dockerfile
+      uses: hadolint/[email protected]
+      with:
+        dockerfile: Dockerfile
+    - name: run hadolint on config daemon dockerfile
+      uses: hadolint/[email protected]
+      with:
+        dockerfile: Dockerfile.sriov-network-config-daemon
+    - name: run hadolint on webhook dockerfile
+      uses: hadolint/[email protected]
+      with:
+        dockerfile: Dockerfile.webhook
   test-coverage:
     name: test-coverage
     runs-on: ubuntu-24.04

Dockerfile

@@ -1,8 +1,8 @@
 FROM golang:1.25 AS builder
 WORKDIR /go/src/github.com/k8snetworkplumbingwg/sriov-network-operator
 COPY . .
-RUN make _build-manager BIN_PATH=build/_output/cmd
-RUN make _build-sriov-network-operator-config-cleanup BIN_PATH=build/_output/cmd
+RUN make _build-manager BIN_PATH=build/_output/cmd && \
+    make _build-sriov-network-operator-config-cleanup BIN_PATH=build/_output/cmd
 
 FROM quay.io/centos/centos:stream9
 COPY --from=builder /go/src/github.com/k8snetworkplumbingwg/sriov-network-operator/build/_output/cmd/manager /usr/bin/sriov-network-operator

Dockerfile.sriov-network-config-daemon

@@ -4,10 +4,10 @@ COPY . .
 RUN make _build-sriov-network-config-daemon BIN_PATH=build/_output/cmd
 
 FROM quay.io/centos/centos:stream9
-ARG MSTFLINT=mstflint
+ARG MSTFLINT=mstflint-4.32.0
 # We have to ensure that pciutils is installed. This package is needed for mstfwreset to succeed.
 # xref pkg/vendors/mellanox/mellanox.go#L150
-RUN ARCH_DEP_PKGS=$(if [ "$(uname -m)" != "s390x" ]; then echo -n ${MSTFLINT} ; fi) && yum -y install hwdata pciutils $ARCH_DEP_PKGS && yum clean all
+RUN ARCH_DEP_PKGS=$(if [ "$(uname -m)" != "s390x" ]; then echo -n "${MSTFLINT}" ; fi) && yum -y install hwdata pciutils "${ARCH_DEP_PKGS}" && yum clean all
 LABEL io.k8s.display-name="sriov-network-config-daemon" \
       io.k8s.description="This is a daemon that manage and config sriov network devices in Kubernetes cluster"
 COPY --from=builder /go/src/github.com/k8snetworkplumbingwg/sriov-network-operator/build/_output/cmd/sriov-network-config-daemon /usr/bin/