Merge pull request #6881 from LivingCcj/remark_workload_of_resourcebinding

remark the workload for resourcebinding

Author: karmada-bot

pkg/apis/work/v1alpha2/binding_types_helper.go

@@ -213,3 +213,12 @@ func (s *ResourceBindingSpec) SchedulePriorityValue() int32 {
 	}
 	return s.SchedulePriority.Priority
 }
+
+// IsWorkload return true if the ResourceBinding represents workload which has replicas or replica requirements (e.g., Deployment, StatefulSet)
+// or multi-component workloads (e.g., FlinkDeployment), false otherwise.
+func (s *ResourceBindingSpec) IsWorkload() bool {
+	if s.Replicas > 0 || s.ReplicaRequirements != nil || len(s.Components) >= 1 {
+		return true
+	}
+	return false
+}

pkg/apis/work/v1alpha2/binding_types_helper_test.go

@@ -20,6 +20,8 @@ import (
 	"reflect"
 	"testing"
 
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
 	"k8s.io/utils/ptr"
 
 	policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1"
@@ -441,3 +443,84 @@ func TestResourceBindingSpec_SchedulingSuspended(t *testing.T) {
 		})
 	}
 }
+
+func TestResourceBindingSpec_IsWorkload(t *testing.T) {
+	tests := []struct {
+		name string
+		spec *ResourceBindingSpec
+		want bool
+	}{
+		{
+			name: "binding an object with replicas",
+			spec: &ResourceBindingSpec{
+				Replicas: 1,
+			},
+			want: true,
+		},
+		{
+			name: "binding an object when replicas is 0",
+			spec: &ResourceBindingSpec{
+				Replicas: 0,
+			},
+			want: false,
+		},
+		{
+			name: "binding an object with ReplicaRequirement",
+			spec: &ResourceBindingSpec{
+				ReplicaRequirements: &ReplicaRequirements{
+					ResourceRequest: corev1.ResourceList{
+						corev1.ResourceCPU:    resource.MustParse("100m"),
+						corev1.ResourceMemory: resource.MustParse("200Mi"),
+					},
+				},
+			},
+			want: true,
+		},
+		{
+			name: "binding an object with no ReplicaRequirement",
+			spec: &ResourceBindingSpec{
+				ReplicaRequirements: nil,
+			},
+			want: false,
+		},
+		{
+			name: "binding an object with single component",
+			spec: &ResourceBindingSpec{
+				Components: []Component{
+					{
+						Name:                "comp1",
+						Replicas:            1,
+						ReplicaRequirements: nil,
+					},
+				},
+			},
+			want: true,
+		},
+		{
+			name: "binding an object with multiple components",
+			spec: &ResourceBindingSpec{
+				Components: []Component{
+					{
+						Name:                "comp1",
+						Replicas:            1,
+						ReplicaRequirements: nil,
+					},
+					{
+						Name:                "comp2",
+						Replicas:            1,
+						ReplicaRequirements: nil,
+					},
+				},
+			},
+			want: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			ret := tt.spec.IsWorkload()
+			if ret != tt.want {
+				t.Fatalf("want %v, got %v", tt.want, ret)
+			}
+		})
+	}
+}

pkg/scheduler/scheduler.go

@@ -420,7 +420,7 @@ func (s *Scheduler) doScheduleBinding(namespace, name string) (err error) {
 		metrics.BindingSchedule(string(ReconcileSchedule), utilmetrics.DurationInSeconds(start), err)
 		return err
 	}
-	if rb.Spec.Replicas == 0 ||
+	if !rb.Spec.IsWorkload() ||
 		rb.Spec.Placement.ReplicaSchedulingType() == policyv1alpha1.ReplicaSchedulingTypeDuplicated {
 		// Duplicated resources should always be scheduled. Note: non-workload is considered as duplicated
 		// even if scheduling type is divided.
@@ -496,7 +496,7 @@ func (s *Scheduler) doScheduleClusterBinding(name string) (err error) {
 		metrics.BindingSchedule(string(ReconcileSchedule), utilmetrics.DurationInSeconds(start), err)
 		return err
 	}
-	if crb.Spec.Replicas == 0 ||
+	if !crb.Spec.IsWorkload() ||
 		crb.Spec.Placement.ReplicaSchedulingType() == policyv1alpha1.ReplicaSchedulingTypeDuplicated {
 		// Duplicated resources should always be scheduled. Note: non-workload is considered as duplicated
 		// even if scheduling type is divided.