Skip to content

Commit b656922

Browse files
committed
prevent releasing an app that have org.test or org.kivy as domain. Closes #500
1 parent e2b46c0 commit b656922

File tree

1 file changed

+31
-1
lines changed

1 file changed

+31
-1
lines changed

buildozer/target.py

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,38 @@ def cmd_debug(self, *args):
103103
self.buildozer.build()
104104

105105
def cmd_release(self, *args):
106+
error = self.buildozer.error
106107
self.buildozer.prepare_for_build()
108+
if self.buildozer.config.get("app", "package.domain") == "org.test":
109+
error("")
110+
error("ERROR: Trying to release a package that starts with org.test")
111+
error("")
112+
error("The package.domain org.test is, as the name intented, a test.")
113+
error("Once you published an application with org.test,")
114+
error("you cannot change it, it will be part of the identifier")
115+
error("for Google Play / App Store / etc.")
116+
error("")
117+
error("So change package.domain to anything else.")
118+
error("")
119+
error("If you messed up before, set the environment variable to force the build:")
120+
error("export BUILDOZER_ALLOW_ORG_TEST_DOMAIN=1")
121+
error("")
122+
if "BUILDOZER_ALLOW_ORG_TEST_DOMAIN" not in os.environ:
123+
exit(1)
124+
125+
if self.buildozer.config.get("app", "package.domain") == "org.kivy":
126+
error("")
127+
error("ERROR: Trying to release a package that starts with org.kivy")
128+
error("")
129+
error("The package.domain org.kivy is reserved for the Kivy official")
130+
error("applications. Please use your own domain.")
131+
error("")
132+
error("If you are a Kivy developer, add an export in your shell")
133+
error("export BUILDOZER_ALLOW_KIVY_ORG_DOMAIN=1")
134+
error("")
135+
if "BUILDOZER_ALLOW_KIVY_ORG_DOMAIN" not in os.environ:
136+
exit(1)
137+
107138
self.build_mode = 'release'
108139
self.buildozer.build()
109140

@@ -115,4 +146,3 @@ def cmd_run(self, *args):
115146

116147
def cmd_serve(self, *args):
117148
self.buildozer.cmd_serve()
118-

0 commit comments

Comments
 (0)