Merge pull request #4491 from kiwix/Fixes#4490

Cleanup codebase.

Author: kelson42

app/src/main/java/org/kiwix/kiwixmobile/localFileTransfer/KiwixWifiP2pBroadcastReceiver.kt

@@ -52,6 +52,7 @@ class KiwixWifiP2pBroadcastReceiver(
         val wifiP2pState = intent.getIntExtra(EXTRA_WIFI_STATE, -1)
         p2pEventListener.onWifiP2pStateChanged(wifiP2pState == WIFI_P2P_STATE_ENABLED)
       }
+
       WIFI_P2P_PEERS_CHANGED_ACTION -> p2pEventListener.onPeersChanged()
       WIFI_P2P_CONNECTION_CHANGED_ACTION -> {
         val networkInfo =
@@ -67,6 +68,7 @@ class KiwixWifiP2pBroadcastReceiver(
           p2pEventListener.onConnectionChanged(networkInfo.isConnected)
         }
       }
+
       WIFI_P2P_THIS_DEVICE_CHANGED_ACTION -> {
         val userDevice =
           if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/online/DownloadBookItem.kt

@@ -62,7 +62,7 @@ import org.kiwix.kiwixmobile.core.zim_manager.Byte
 import org.kiwix.kiwixmobile.ui.BookDescription
 import org.kiwix.kiwixmobile.ui.BookIcon
 import org.kiwix.kiwixmobile.ui.BookTitle
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.LibraryDownloadItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.LibraryDownloadItem
 
 const val DOWNLOAD_BOOK_ITEM_TESTING_TAG = "downloadBookItemTestingTag"
 const val DOWNLOADING_PAUSE_BUTTON_TESTING_TAG = "downloadingPauseButtonTestingTag"

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/online/OnlineBookItem.kt

@@ -66,7 +66,7 @@ import org.kiwix.kiwixmobile.ui.TagsView
 import org.kiwix.kiwixmobile.zimManager.Fat32Checker.FileSystemState.CannotWrite4GbFile
 import org.kiwix.kiwixmobile.zimManager.Fat32Checker.FileSystemState.DetectingFileSystem
 import org.kiwix.kiwixmobile.zimManager.libraryView.AvailableSpaceCalculator
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.BookItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.BookItem
 
 const val ONLINE_BOOK_ITEM_TESTING_TAG = "onlineBookItemTestingTag"
 const val ONLINE_BOOK_SIZE_TEXT_TESTING_TAG = "onlineBookSizeTextTestingTag"

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/online/OnlineLibraryFragment.kt

@@ -96,7 +96,7 @@ import org.kiwix.kiwixmobile.ui.KiwixDestination
 import org.kiwix.kiwixmobile.zimManager.ZimManageViewModel
 import org.kiwix.kiwixmobile.zimManager.ZimManageViewModel.OnlineLibraryRequest
 import org.kiwix.kiwixmobile.zimManager.libraryView.AvailableSpaceCalculator
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem
 import javax.inject.Inject
 
 const val LANGUAGE_MENU_ICON_TESTING_TAG = "languageMenuIconTestingTag"

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/online/OnlineLibraryScreen.kt

@@ -83,8 +83,8 @@ import org.kiwix.kiwixmobile.core.utils.ComposeDimens.FOUR_DP
 import org.kiwix.kiwixmobile.core.utils.ComposeDimens.SIXTEEN_DP
 import org.kiwix.kiwixmobile.core.utils.ComposeDimens.SIX_DP
 import org.kiwix.kiwixmobile.core.utils.ComposeDimens.THREE_DP
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.DividerItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.DividerItem
 
 const val ONLINE_LIBRARY_SEARCH_VIEW_TESTING_TAG = "onlineLibrarySearchViewTestingTag"
 const val ONLINE_LIBRARY_SEARCH_VIEW_CLOSE_BUTTON_TESTING_TAG =

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/online/OnlineLibraryScreenState.kt

@@ -21,9 +21,9 @@ package org.kiwix.kiwixmobile.nav.destination.library.online
 import androidx.compose.material3.SnackbarHostState
 import org.kiwix.kiwixmobile.core.utils.BookUtils
 import org.kiwix.kiwixmobile.zimManager.libraryView.AvailableSpaceCalculator
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.BookItem
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.LibraryDownloadItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.BookItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.LibraryDownloadItem
 
 data class OnlineLibraryScreenState(
   /**

app/src/main/java/org/kiwix/kiwixmobile/zimManager/FileWritingFileSystemChecker.kt

@@ -32,6 +32,7 @@ class FileWritingFileSystemChecker : FileSystemChecker {
       when (val capability = readCapability(resultFile)) {
         CAN_WRITE_4GB,
         CANNOT_WRITE_4GB -> return capability
+
         else -> {}
       }
     }
@@ -57,7 +58,7 @@ class FileWritingFileSystemChecker : FileSystemChecker {
   private fun readCapability(resultFile: File) =
     try {
       FileSystemCapability.valueOf(resultFile.readText())
-    } catch (illegalArgumentException: IllegalArgumentException) {
+    } catch (_: IllegalArgumentException) {
       INCONCLUSIVE
     }
 

app/src/main/java/org/kiwix/kiwixmobile/zimManager/ZimManageViewModel.kt

@@ -111,10 +111,10 @@ import org.kiwix.kiwixmobile.zimManager.fileselectView.effects.None
 import org.kiwix.kiwixmobile.zimManager.fileselectView.effects.OpenFileWithNavigation
 import org.kiwix.kiwixmobile.zimManager.fileselectView.effects.ShareFiles
 import org.kiwix.kiwixmobile.zimManager.fileselectView.effects.StartMultiSelection
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.BookItem
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.DividerItem
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem.LibraryDownloadItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.BookItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.DividerItem
+import org.kiwix.kiwixmobile.zimManager.libraryView.LibraryListItem.LibraryDownloadItem
 import org.kiwix.libkiwix.Book
 import retrofit2.Response
 import java.util.concurrent.TimeUnit.SECONDS
@@ -124,7 +124,6 @@ const val DEFAULT_PROGRESS = 0
 const val MAX_PROGRESS = 100
 
 const val THREE = 3
-const val FOUR = 4
 
 class ZimManageViewModel @Inject constructor(
   private val downloadDao: DownloadRoomDao,

app/src/main/java/org/kiwix/kiwixmobile/zimManager/libraryView/AvailableSpaceCalculator.kt

@@ -25,7 +25,6 @@ import org.kiwix.kiwixmobile.core.dao.DownloadRoomDao
 import org.kiwix.kiwixmobile.core.downloader.model.DownloadModel
 import org.kiwix.kiwixmobile.core.entity.LibkiwixBook
 import org.kiwix.kiwixmobile.core.settings.StorageCalculator
-import org.kiwix.kiwixmobile.zimManager.libraryView.adapter.LibraryListItem
 import javax.inject.Inject
 
 class AvailableSpaceCalculator @Inject constructor(

app/src/main/java/org/kiwix/kiwixmobile/zimManager/libraryView/adapter/LibraryListItem.kt renamed to app/src/main/java/org/kiwix/kiwixmobile/zimManager/libraryView/LibraryListItem.kt

@@ -16,7 +16,7 @@
  *
  */
 
-package org.kiwix.kiwixmobile.zimManager.libraryView.adapter
+package org.kiwix.kiwixmobile.zimManager.libraryView
 
 import com.tonyodev.fetch2.Error
 import com.tonyodev.fetch2.Status