Find in page conflated with Find in ZIM

[Popolechien]

Basically when I start typing text the "find in page" button disappears and the search only applies to the whole zim.

I would probably advocate that "search" and "find in page" be dissociated (the latter being pushed to a menu item), unless there's an elegant way to switch from or select either on that search bar.

[macgills]

This bug was also fixed in #1771 , the find in page buttons visibility is now controlled by whether or not there is text in the search field.

I do agree that Find In Page should be accessible from the main screen, potentially as an overflow option. It probably wasn't because of the overpopulation of that list that exists now

[kelson42]

Could we split things in two tickets? Here we have a bug which needs to be fixed. The other part is an idea of improvement (which I'm not really in favor of).

[macgills]

The bug is fixed

[macgills]

chrome has Find in Page in its' overflow menu, as an example

[kelson42]

The original discussion about that is at #154. I'm not sure I see new arguments here to chance the current behaviour.

[macgills]

We could try to adopt a more browser like behaviour and abandon the search icon because it is the search icon that is confusing people.

If we had a chrome-like "address bar" at the top with the title in it and we could only open Search by clicking in it then I think people would look in the overflow menu for Find in Page

[Popolechien]

Sounds good/reasonable to me. Obviously the two-in-one approach isn't ideal, so let's shamelessly copy what others have already figured out.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

I will refresh/reassess this ticket.