Skip to content

Conversation

@bharathappali
Copy link
Member

Description

This PR:

CAUTION: MERGE ONLY IF KRUIZE OBJECT CHANGES ARE NEEDED

This PR has the changes for KruizeObject to maintain experiment_type as long internally.

Currently the usage scope for this changes are limited to check if the container and namespace bits are set. Which we will be doing while extracting from DB and setting enum

The advantage of this changes can be seen if we are extensively using bit check instead of enum compare when we add more flags and use it across all kruize subsystems like autotune and recommendation generator. Currently these changes might not give any added advantage and adds a conversion overhead in case of ListExperiments

PLEASE MERGE THIS ONLY IF IT'S NECESSARY RIGHT NOW

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@bharathappali bharathappali added this to the Kruize 0.7_prod release milestone Jul 30, 2025
@bharathappali bharathappali requested a review from dinogun July 30, 2025 05:10
@bharathappali bharathappali self-assigned this Jul 30, 2025
@bharathappali bharathappali added the analyzer Analyzer module related issues label Jul 30, 2025
@rbadagandi1 rbadagandi1 moved this to Under Review in Monitoring Jul 30, 2025
… issue with list experiments

Signed-off-by: bharathappali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analyzer Analyzer module related issues

Projects

Status: Under Review

Development

Successfully merging this pull request may close these issues.

2 participants