Skip to content

Fix Perf Profile Test Failures #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: mvp_demo
Choose a base branch
from
Open

Fix Perf Profile Test Failures #1705

wants to merge 3 commits into from

Conversation

@khansaad
Copy link
Contributor

@khansaad khansaad commented Nov 20, 2025 •
edited
Loading

Description

This PR fixes issues raised during 0.7.1 release namely, #1667 and #1668
Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on: Openshift

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@khansaad khansaad added this to the Kruize 0.8 Release milestone Nov 20, 2025
@khansaad khansaad self-assigned this Nov 20, 2025
@khansaad khansaad added the bug Something isn't working label Nov 20, 2025
@khansaad khansaad moved this to Under Review in Monitoring Nov 20, 2025
This was linked to issues Nov 25, 2025
Validation failure of mandatory fields in the metric profile #1667
Open
Duplicate SLO data negative test failure #1668
Open
shreyabiradar07
shreyabiradar07 approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@shreyabiradar07 shreyabiradar07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyabiradar07 shreyabiradar07 shreyabiradar07 approved these changes

@bharathappali bharathappali Awaiting requested review from bharathappali

Assignees

@khansaad khansaad

Labels

bug Something isn't working

Projects

Monitoring
Status: Under Review

Milestone

Kruize 0.8 Release

Development

Successfully merging this pull request may close these issues.

Duplicate SLO data negative test failure Validation failure of mandatory fields in the metric profile

2 participants

@khansaad @shreyabiradar07