Fix cache reset thread safety and benchmark test name mappings

Acquire exclusive access via atomic_exchange before resetting cache
storage in ksdl_resetCache() and ksbic_resetCache(). This follows the
same lock-free pattern used by the lookup functions.

Also update workflow benchmark test names to match actual test names
and add missing cache miss variants.

Author: naftaly

.github/workflows/benchmarks.yml

@@ -174,10 +174,13 @@ jobs:
               "BinaryImageForHeaderAll": "Binary image info (all)",
               "TypicalCrashSymbolication": "Typical crash symbolication",
               "FullCrashReport": "Full crash report generation",
-              "RepeatedSameAddressLookup": "Repeated same address lookup",
-              "SequentialNearbyAddresses": "Sequential nearby addresses",
-              "ExactFunctionAddressLookup": "Exact function address lookup",
-              "NonExactAddressLookup": "Non-exact address lookup",
+              "RepeatedLookupCacheHit": "Repeated lookup (cache hit)",
+              "RepeatedLookupCacheMiss": "Repeated lookup (cache miss)",
+              "SequentialNearbyAddressesCacheHit": "Sequential nearby addresses (cache hit)",
+              "ExactFunctionLookupCacheHit": "Exact function lookup (cache hit)",
+              "ExactFunctionLookupCacheMiss": "Exact function lookup (cache miss)",
+              "NonExactLookupCacheHit": "Non-exact lookup (cache hit)",
+              "NonExactLookupCacheMiss": "Non-exact lookup (cache miss)",
               "IsMemoryReadableSmall": "Check readable (64B)",
               "IsMemoryReadablePage": "Check readable (4KB)",
               "IsMemoryReadableLarge": "Check readable (64KB)",

Sources/KSCrashRecordingCore/KSBinaryImageCache.c

@@ -253,8 +253,19 @@ const ks_dyld_image_info *ksbic_getImages(uint32_t *count)
 void ksbic_resetCache(void)
 {
     g_all_image_infos = NULL;
-    g_cache_storage.count = 0;
-    atomic_store(&g_cache_ptr, &g_cache_storage);
+
+    // Acquire exclusive access to the cache before resetting
+    KSBinaryImageRangeCache *cache = atomic_exchange(&g_cache_ptr, NULL);
+    if (cache != NULL) {
+        cache->count = 0;
+        atomic_store(&g_cache_ptr, cache);
+    } else {
+        // Cache is in use by another thread - reset storage directly
+        // and restore pointer (the other thread will see stale data but
+        // that's acceptable for a reset operation)
+        g_cache_storage.count = 0;
+        atomic_store(&g_cache_ptr, &g_cache_storage);
+    }
 }
 
 const struct mach_header *ksbic_findImageForAddress(uintptr_t address, uintptr_t *outSlide, const char **outName)

Sources/KSCrashRecordingCore/KSDynamicLinker.c

@@ -90,10 +90,22 @@ void ksdl_init(void)
 
 void ksdl_resetCache(void)
 {
-    // Reset both caches and allow re-initialization
+    // Reset binary image cache first (it has its own locking)
     ksbic_resetCache();
-    g_symbol_cache_storage.count = 0;
-    atomic_store(&g_symbol_cache_ptr, &g_symbol_cache_storage);
+
+    // Acquire exclusive access to the symbol cache before resetting
+    KSSymbolCache *cache = atomic_exchange(&g_symbol_cache_ptr, NULL);
+    if (cache != NULL) {
+        cache->count = 0;
+        atomic_store(&g_symbol_cache_ptr, cache);
+    } else {
+        // Cache is in use by another thread - reset storage directly
+        // and restore pointer (the other thread will see stale data but
+        // that's acceptable for a reset operation)
+        g_symbol_cache_storage.count = 0;
+        atomic_store(&g_symbol_cache_ptr, &g_symbol_cache_storage);
+    }
+
     atomic_store(&g_initialized, false);
 }