Skip to content

Commit 2fed288

Browse files
committed
Add crds and other remaining resources
Signed-off-by: kunal-511 <[email protected]>
1 parent ef8c9cd commit 2fed288

File tree

14 files changed

+9595
-56
lines changed

14 files changed

+9595
-56
lines changed
Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
# Values for base deployment mode
2+
deploymentMode: standalone
3+
4+
# Override names
5+
nameOverride: ""
6+
fullnameOverride: ""
7+
8+
global:
9+
namespace: notebook-controller-system
10+
imageRegistry: ghcr.io/kubeflow/kubeflow
11+
imageTag: v1.10.0
12+
13+
# Common labels
14+
commonLabels:
15+
app: notebook-controller
16+
kustomize.component: notebook-controller
17+
18+
controller:
19+
config:
20+
useIstio: true
21+
istioGateway: "kubeflow/kubeflow-gateway"
22+
istioHost: "*"
23+
clusterDomain: "cluster.local"
24+
enableCulling: false
25+
cullIdleTime: "1440"
26+
idlenessCheckPeriod: "1"
27+
28+
manager:
29+
enableLeaderElection: true
30+
metricsAddr: "0.0.0.0:8080"
31+
healthProbeAddr: ":8081"
32+
33+
# Disable auth proxy in base mode
34+
authProxy:
35+
enabled: false
36+
37+
# Webhook disabled by default
38+
webhook:
39+
enabled: false
40+
41+
# Security context
42+
podSecurityContext:
43+
seccompProfile:
44+
type: RuntimeDefault
45+
46+
securityContext:
47+
runAsNonRoot: true
48+
allowPrivilegeEscalation: false
49+
runAsUser: 1000
50+
capabilities:
51+
drop:
52+
- ALL
53+
54+
# Enable main service
55+
service:
56+
enabled: true
57+
type: ClusterIP
58+
port: 443
59+
60+
# Disable metrics service in base (no auth proxy)
61+
metricsService:
62+
enabled: false
63+
64+
# RBAC
65+
rbac:
66+
create: true
67+
serviceAccount:
68+
create: true
69+
name: ""
70+
authProxy:
71+
enabled: false
72+
leaderElection:
73+
enabled: true
74+
75+
# Enable direct metrics without auth proxy
76+
monitoring:
77+
enabled: true
78+
prometheus:
79+
enabled: true
80+
podAnnotations:
81+
prometheus.io/scrape: "true"
82+
prometheus.io/port: "8080"
83+
prometheus.io/path: "/metrics"
84+
85+
# CRD management with patches
86+
crds:
87+
install: true
88+
validationPatches:
89+
enabled: true
90+
91+
kustomizeMode:
92+
enabled: true
93+
useOriginalLabels: true
94+
useOriginalNames: true
95+
96+
# Disable samples
97+
samples:
98+
enabled: false
99+
namespace: "default"

experimental/helm/charts/notebook-controller/ci/kubeflow-values.yaml

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,9 @@ controller:
2828
metricsAddr: "127.0.0.1:8080"
2929
healthProbeAddr: ":8081"
3030

31-
# Enable auth proxy for metrics protection in Kubeflow
31+
# Disable auth proxy
3232
authProxy:
33-
enabled: true
34-
image:
35-
registry: quay.io
36-
repository: brancz/kube-rbac-proxy
37-
tag: v0.4.0
33+
enabled: false
3834

3935
# Webhook server disabled by default
4036
webhook:
@@ -59,15 +55,9 @@ service:
5955
type: ClusterIP
6056
port: 443
6157

62-
# Enable metrics service for Prometheus scraping (matches auth_proxy_service.yaml)
58+
# Disable metrics service
6359
metricsService:
64-
enabled: true
65-
annotations:
66-
prometheus.io/port: "8443"
67-
prometheus.io/scheme: https
68-
prometheus.io/scrape: "true"
69-
labels:
70-
control-plane: controller-manager
60+
enabled: false
7161

7262
# RBAC
7363
rbac:
@@ -76,7 +66,7 @@ rbac:
7666
create: true
7767
name: ""
7868
authProxy:
79-
enabled: true
69+
enabled: false
8070
leaderElection:
8171
enabled: true
8272

experimental/helm/charts/notebook-controller/ci/standalone-values.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Values for standalone deployment mode
22
deploymentMode: standalone
33

4+
# Override names
5+
nameOverride: ""
6+
fullnameOverride: ""
7+
48
global:
59
namespace: notebook-controller-system
610
imageRegistry: ghcr.io/kubeflow/kubeflow
@@ -14,6 +18,8 @@ commonLabels:
1418
controller:
1519
config:
1620
useIstio: false
21+
istioGateway: "kubeflow/kubeflow-gateway"
22+
istioHost: "*"
1723
clusterDomain: "cluster.local"
1824
enableCulling: false
1925
cullIdleTime: "1440"
@@ -87,7 +93,7 @@ kustomizeMode:
8793
useOriginalLabels: true
8894
useOriginalNames: true
8995

90-
# Enable samples for testing in standalone mode
96+
# Disable samples
9197
samples:
92-
enabled: true
98+
enabled: false
9399
namespace: "default"

0 commit comments

Comments
 (0)