Find button by text exactly

[Barbapapazes]

Dusk Version

8.x

Laravel Version

11.x

PHP Version

8.4

PHPUnit Version

10.x

Database Driver & Version

/

Description

Hello 👋,

The method pressAndWaitFor uses the method findButtonByText (

dusk/src/ElementResolver.php

Lines 296 to 309 in ae5a90c

	/**
	* Resolve the element for a given button by text.
	*
	* @param string $button
	* @return \Facebook\WebDriver\Remote\RemoteWebElement|null
	*/
	protected function findButtonByText($button)
	{
	foreach ($this->all('button') as $element) {
	if (Str::contains($element->getText(), $button)) {
	return $element;
	}
	}
	}

) that does not try to resolve the button with exactly its name but with a name that contains the parameter. This is an issue when there is multiple button on the page.

For example, you can have the button Create Application and another button Create but you won't be able to target Create because Create Application will always be resolved first (if it appears fist in the DOM).

Steps To Reproduce

1. Create a button Create Application
2. Create a button Create
3. Try to use the method pressAndWaitFor to select the Create but Dusk will try to press Create Application.

[Bryce-Stabenow]

@Barbapapazes Would you be proposing to add an additional (optional) parameter that would force the text match exactly? In my own personal usage, I find it more resilient to use selectors that are not based on innerText of elements when possible, opting to give elements their own [data-dusk=""] attributes instead.