Skip to content

Commit e15cb6b

Browse files
committed
fix: in viewport retriever JS
1 parent a3190b6 commit e15cb6b

File tree

2 files changed

+10
-3
lines changed
  • lavague-integrations/drivers/lavague-drivers-selenium/lavague/drivers/selenium
  • lavague-sdk/lavague/sdk/base_driver

2 files changed

+10
-3
lines changed

lavague-integrations/drivers/lavague-drivers-selenium/lavague/drivers/selenium/base.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
from selenium.webdriver.support.ui import WebDriverWait
4040
from selenium.webdriver.chrome.service import Service
4141

42+
4243
class SeleniumDriver(BaseDriver[SeleniumNode]):
4344
driver: WebDriver
4445

@@ -186,6 +187,7 @@ def get_possible_interactions(
186187
self,
187188
in_viewport=True,
188189
foreground_only=True,
190+
include_non_interactives=False,
189191
types: List[InteractionType] = [
190192
InteractionType.CLICK,
191193
InteractionType.TYPE,
@@ -197,12 +199,14 @@ def get_possible_interactions(
197199
JS_GET_INTERACTIVES,
198200
in_viewport,
199201
foreground_only,
200-
False,
202+
include_non_interactives,
201203
[t.name for t in types],
202204
)
203205
res = dict()
204206
for k, v in exe.items():
205-
res[k] = set(InteractionType[i] for i in v)
207+
res[k] = set(
208+
InteractionType[i] for i in v if i in InteractionType.__members__
209+
)
206210
return res
207211

208212
def scroll_into_view(self, xpath: str):

lavague-sdk/lavague/sdk/base_driver/base.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ def get_possible_interactions(
139139
self,
140140
in_viewport=True,
141141
foreground_only=True,
142+
include_non_interactives=False,
142143
types: List[InteractionType] = [
143144
InteractionType.CLICK,
144145
InteractionType.TYPE,
@@ -232,7 +233,9 @@ def get_obs(self) -> DriverObservation:
232233

233234
def get_in_viewport(self) -> List[str]:
234235
"""Get xpath of elements in the viewport"""
235-
interactions = self.get_possible_interactions(in_viewport=True, types=[])
236+
interactions = self.get_possible_interactions(
237+
include_non_interactives=True, types=[]
238+
)
236239
return list(interactions.keys())
237240

238241
def get_scroll_containers(self) -> List[str]:

0 commit comments

Comments
 (0)