fix: give TestResult.success (.inl ()) higher priority than .gaveUp
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom93
force-pushed
the
pr/fix-success-gaveUp-priority
branch
from
ab6f67e to
bde0bca
Compare
tom93
changed the title
TestResult.success (.inl ()) higher priority than .gaveUpTestResult.success (.inl ()) higher priority than .gaveUp
If some runs succeeded and some runs didn't produce a well-formed example, then the overall result should be that some runs succeeded, not that we couldn't generate a well-formed example. (The handling of `TestResult.success (.inr h)` is unchanged -- it already had higher priority than `.gaveUp`, and further it triggers immediate termination because it has a positive proof.) Fixes leanprover-community#15.
tom93
force-pushed
the
pr/fix-success-gaveUp-priority
branch
from
bde0bca to
c6dc2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my attempt at a fix for #15. Please check that my my idea is correct; from the commit message: