Skip to content

Commit 76ae31b

Browse files
authored
Fixes folders or resources with missing title remain 'incomplete' after editing just the title (#5539)
* 000 * updates the completion status when quick editing a channel folder * update assertions in EditTitleDescriptionModa * revert pilow to pillow==11.3.0 * replace objectContaining with full payload check
1 parent 8ee2083 commit 76ae31b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditTitleDescriptionModal.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@
9898
id: nodeId,
9999
title: title.trim(),
100100
description: description.trim(),
101+
checkComplete: true,
101102
});
102103
/* eslint-disable-next-line kolibri/vue-no-undefined-string-uses */
103104
this.$store.dispatch('showSnackbarSimple', commonStrings.$tr('changesSaved'));

contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/__tests__/EditTitleDescriptionModal.spec.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ describe('EditTitleDescriptionModal', () => {
3333
},
3434
},
3535
}),
36-
propsData: {
37-
nodeId,
38-
},
36+
propsData: { nodeId },
3937
});
4038

4139
updateContentNode = jest.spyOn(wrapper.vm, 'updateContentNode').mockImplementation(() => {});
@@ -70,7 +68,8 @@ describe('EditTitleDescriptionModal', () => {
7068
expect(updateContentNode).toHaveBeenCalledWith({
7169
id: nodeId,
7270
title: newTitle,
73-
description: newDescription,
71+
description: newDescription ?? '',
72+
checkComplete: true,
7473
});
7574
});
7675

@@ -80,11 +79,11 @@ describe('EditTitleDescriptionModal', () => {
8079
descriptionInput.vm.$emit('input', '');
8180

8281
modal.vm.$emit('submit');
83-
8482
expect(updateContentNode).toHaveBeenCalledWith({
8583
id: nodeId,
8684
title: newTitle,
8785
description: '',
86+
checkComplete: true,
8887
});
8988
});
9089

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ packaging==25.0
178178
# google-cloud-error-reporting
179179
# google-cloud-kms
180180
# gunicorn
181-
pillow==11.1.0
181+
pillow==11.3.0
182182
# via -r requirements.in
183183
prometheus-client==0.10.1
184184
# via django-prometheus

0 commit comments

Comments
 (0)