implement freeResponse valdation in getters instead

Author: ozer550

contentcuration/contentcuration/frontend/channelEdit/vuex/assessmentItem/getters.js

@@ -1,6 +1,5 @@
+import { AssessmentItemTypes, ContentModalities, DELAYED_VALIDATION } from 'shared/constants';
 import { getAssessmentItemErrors } from 'shared/utils/validation';
-import { DELAYED_VALIDATION } from 'shared/constants';
-
 /**
  * Get assessment items of a node.
  */
@@ -33,18 +32,23 @@ export function getAssessmentItemsErrors(state, getters, rootState, rootGetters)
     const assessmentItemsErrors = {};
 
     const contentNode = rootGetters['contentNode/getContentNode'](contentNodeId);
+    const modality = contentNode?.extra_fields?.options?.modality;
 
     if (!state.assessmentItemsMap || !state.assessmentItemsMap[contentNodeId]) {
       return assessmentItemsErrors;
     }
     Object.keys(state.assessmentItemsMap[contentNodeId]).forEach(assessmentItemId => {
       const assessmentItem = state.assessmentItemsMap[contentNodeId][assessmentItemId];
+      const freeResponseInvalid =
+        modality !== ContentModalities.SURVEY &&
+        assessmentItem.type === AssessmentItemTypes.FREE_RESPONSE;
+
       if (ignoreDelayed && assessmentItem[DELAYED_VALIDATION]) {
         assessmentItemsErrors[assessmentItemId] = [];
       } else {
         assessmentItemsErrors[assessmentItemId] = getAssessmentItemErrors(
           assessmentItem,
-          contentNode
+          freeResponseInvalid
         );
       }
     });

contentcuration/contentcuration/frontend/shared/utils/validation.js

@@ -534,9 +534,8 @@ export function sanitizeAssessmentItem(assessmentItem, removeEmpty = false) {
  * @param {Object} assessmentItem An assessment item.
  * @returns {Array} An array of error codes.
  */
-export function getAssessmentItemErrors(assessmentItem, contentNode) {
+export function getAssessmentItemErrors(assessmentItem, freeResponseInvalid = false) {
   const errors = [];
-  const modality = contentNode?.extra_fields?.options?.modality;
 
   // Don't validate perseus questions
   if (assessmentItem.type === AssessmentItemTypes.PERSEUS_QUESTION) {
@@ -557,10 +556,7 @@ export function getAssessmentItemErrors(assessmentItem, contentNode) {
   if (!assessmentItem.question || !assessmentItem.question.trim()) {
     errors.push(ValidationErrors.QUESTION_REQUIRED);
   }
-  if (
-    modality !== ContentModalities.SURVEY &&
-    assessmentItem.type == AssessmentItemTypes.FREE_RESPONSE
-  ) {
+  if (freeResponseInvalid) {
     errors.push(ValidationErrors.INVALID_COMPLETION_TYPE_FOR_FREE_RESPONSE_QUESTION);
   }