Skip to content

[Remove Vuetify from Studio] Cards in My Channels #5227

@MisRob

Description

@MisRob

🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:

  • Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
  • Confirm that you’ve read the guidelines in your comment.

Sub-issue of #5060.

Complexity: High

Summary

Remove Vuetify from the channel list in Channels > My Channels.

Image

Currently, ChannelList.vue and ChannelItem.vue that are built with several Vuetify components are used to display the channel list.

To remove these Vuetify dependencies from My Channels, create a new component channelList/views/StudioMyChannels.vue and then update

{
name: RouteNames.CHANNELS_EDITABLE,
path: '/my-channels',
component: ChannelList,
props: { listType: ChannelListTypes.EDITABLE },
},

to

  {
    name: RouteNames.CHANNELS_EDITABLE,
    path: '/my-channels',
    component: StudioMyChannels
  }

Do not modifify ChannelList.vue and ChannelItem.vue.

StudioMyChannels requirements

  • Contains button and card list built with:
    • KButton for New channel button
    • KCardGrid with 1-1-1 layout and KCard in horizontal orientation and small thumbnail for cards list
    • KIconButton with KDropdownMenu for card dropdown
    • KModal for Delete this channel dialog
  • dir="auto" and notranslate class needs to be applied on channel description and name
  • With useKResponsiveWindow detect whether windowIsSmall. If yes, change card layout to vertical. See KCardGrid: Fine-tuning responsiveness.
  • Follow KCard: Interactive elements to implement footer info icon as a router link and make Ctrl+click/enter open the channel details in a new tab.
  • For footer star icon, use existing ChannelStar.vue
  • For thumbnail area, don't use Thumbnail.vue. Use KCard features for managing the thumbnail area. Preserve placeholder icon responsive behavior as browser window resizes. Follow KCard: Thumbnail and KIcon: Responsive
  • Use KCardGrid skeleton loaders when channel data is loading
  • For JavaScript logic for fetching and ordering channels, and creating a new channel, copy code from ChannelList.vue
    • Note listType prop removal from RouteNames.CHANNELS_EDITABLE route above. In contrast to shared ChannelList that is re-used from multiple pages and requires related conditional logic, StudioMyChannels will be only used from My Channels. Therefore, do not add listType prop to StudioMyChannels. Preserve only logic that was previously related to ChannelListTypes.EDITABLE type. Cleanup copied code to not contain listType conditions and code for other types, such as ChannelListTypes.PUBLIC.
  • Not all features (e.g. View channel on Kolibri dropdown option) are always apparent in My Channels, depending on channel type. Examine ChannelItem and migrate all conditional features that are relevant to My Channels.

Guidance

Out of Scope

  • Do not refactor any other areas of the codebase
  • Do not modify ChannelList.vue and ChannelItem.vue and their children components
  • Skip Copy channel token modal (addressed in another pull request)

Expected UI/UX changes

  • Minor visual differences naturally stemming from the use of KDS
    • Aspect ratio and size of card thumbnail area

Acceptance criteria

General

  • The specification above is followed.
  • Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
  • All user interactions are manually tested with no regressions.
  • Pull request includes screenshots.

a11y and i18n

See the project's "Guidance" for useful references.

  • Implementation meets a11y standards
  • All components are LTR and RTL compliant
  • All user-facing strings are translated properly
  • The notranslate class has been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text)
  • Mobile experience is reasonable

Unit tests

  • If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
  • If there is no unit test suite, a new one is created. Do not use obsolete @vue/test-utils approach. Instead, use @testing-library/vue (Vue Testing Library).

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions