-
Notifications
You must be signed in to change notification settings - Fork 257
Infra File Cleanup #5596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DXCanas
wants to merge
11
commits into
learningequality:hotfixes
Choose a base branch
from
DXCanas:studio-infra-file-cleanup
base: hotfixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Infra File Cleanup #5596
DXCanas
wants to merge
11
commits into
learningequality:hotfixes
from
DXCanas:studio-infra-file-cleanup
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not appear to be used anywhere.
Doing as a single commit in case of ressurection.
cddc677 to
aae5494
Compare
DXCanas
commented
Dec 4, 2025
Comment on lines
11
to
13
| # Really seems like it _should_ be here, as it's referenced by `nginx.conf`. | ||
| # But it's hasn't been for years. | ||
| # COPY ${SRC_DIR}/mime.types /etc/nginx/mime.types |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd thing I found 🤷
…ndard. And deleting defunct cloudbuild prod yaml
Making a separate commit for bookmarking purposes. Seems we used to deploy to a separate/distinct dev cluster, and create new postgres instances for every single pr.
Standardizing on image-specific docker locations.
Will delete after both have been updated.
0de1409 to
0c39da8
Compare
Member
Author
|
It doesn't look it, but I did make sure to register file movements, renames, etc with git. In GH, the file history looks incomplete. But if you |
645e5a5 to
1394aba
Compare
anguyen1234
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleaning up infra-related files that no longer appear to be in use. Tried to bundle mass deletions by subject so we can go back for history.
Of Historical Note:
References
#5520
https://github.com/learningequality/infrastructure/issues/853
Reviewer guidance
It might be clearer to go commit-by-commit rather than seeing the full file changelog.
Really, I'm asking for y'all to make sure there are no breaking changes for the local dev workflow (I will deal with consequences to infra-side)