chore(files): declare AWS SDK as optionalDependencies for the s3/rustfs driver#159
Merged
Merged
Conversation
added 2 commits
May 21, 2026 15:09
…fs driver The s3/rustfs storage driver in src/core/files lazy-imports @aws-sdk/client-s3 + @aws-sdk/s3-request-presigner, but they were not declared anywhere — so any consumer setting FEATURE_FILES_STORAGE_DEFAULT=s3 or rustfs hit a boot failure with the masked-but-now-descriptive "failed to load @aws-sdk/client-s3" error. Declares both as optionalDependencies (local/postgres drivers stay zero-cost; s3/rustfs consumers get them resolved automatically) and documents the requirement in .env.example next to the driver toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/core/filesships ans3/rustfsstorage driver that lazy-imports@aws-sdk/client-s3and@aws-sdk/s3-request-presigner, but neither package was declared inpackage.json. Any consumer settingFEATURE_FILES_STORAGE_DEFAULT=s3orrustfstherefore fails to boot — the storage factory throwsaws-s3-operations: failed to load @aws-sdk/client-s3 — run bun add ….(Companion to #158, which stops that error being masked as
[ExceptionHandler] {}.)Fix
@aws-sdk/client-s3+@aws-sdk/s3-request-presignerasoptionalDependencies— thelocal/postgresdrivers stay zero-cost (optional deps that fail to install don't breaklocal), whiles3/rustfsconsumers get them resolved automatically..env.examplenext to theFEATURE_FILES_STORAGE_DEFAULTtoggle.bun installresolves both packages; package.json remains valid.