server: return 403 on unregistered onboarding cert/serial#155
Merged
Conversation
The /register handler currently returns 401 Unauthorized when the auth-container signature has already verified upstream but the (onboarding cert, serial) combination is not in the controller's pre-registration set. APIv2.md prescribes 403 Forbidden for exactly this case: "Valid credentials without authorization" (line 137 of the /register section), and lines 159-160 repeat that the response "MUST" be 403 when the controller requires pre-registration and a device tries to register without one. 401 stays for the genuine authentication failures handled upstream in apiHandlerv2.register (missing SenderCertHash, malformed sender cert, signature mismatch). The change here is confined to the post-auth authorization decision in registerProcess. EVE's cmd/client already maps 403 to LedBlinkOnboardingFailureNotFound (pkg/pillar/cmd/client/client.go) and carries an XXX comment flagging that the controller side of the spec is not yet honoured; this commit removes that gap. Older EVE that doesn't special-case 403 falls back to the generic "Registration failed" log path, same as it does today for 401 — no regression. A handler test exercising the failure path against an empty memory.DeviceManager confirms the new status code. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
milan-zededa
approved these changes
May 15, 2026
eriknordmark
added a commit
to eriknordmark/eden
that referenced
this pull request
May 15, 2026
Picks up lf-edge/adam#155, which brings the /register handler in line with the eve-api spec (APIv2.md §/register, lines 134-160): cert/serial combinations that verify cryptographically but are not in the controller's pre-registration set now return 403 Forbidden rather than 401 Unauthorized. EVE's pkg/pillar/cmd/client already maps 403 to LedBlinkOnboardingFailureNotFound, so the longstanding eve-api gap on the controller side is now closed. Pinning a specific release rather than the rolling `snapshot` tag keeps the version requirement expressible — if a future eden change needs adam ≥ x.y.z, bumping the constant is the natural way to make that explicit, and stale cached `snapshot` images on contributor machines cannot silently regress. Override at config time remains supported via `eden config set default --key=adam.tag --value=<sha-or-tag>`. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
eriknordmark
added a commit
to eriknordmark/eden
that referenced
this pull request
May 15, 2026
Covers the dark `case http.StatusForbidden` branch in selfRegister (pkg/pillar/cmd/client/client.go:671-672) that raises LedBlinkOnboardingFailureNotFound when the controller rejects an onboarding cert that the device cryptographically possesses but that is not present in the controller's pre-registration set. The branch was effectively unreachable until lf-edge/adam#155 brought adam in line with the eve-api spec (APIv2.md §/register: "Valid credentials without authorization: 403"). The scenario captures every onboard-cert + device record that matches this device's serial, DELETEs them via adam's /admin/onboard and /admin/device admin endpoints, wipes /persist/status/uuid and /persist/checkpoint/controllercerts on EVE, in-VM reboots, asserts LedBlinkCounter=18 (OnboardingFailureNotFound), POSTs the saved onboard cert back, reboots again, and verifies the device reaches LedBlinkCounter=4 (Onboarded) with a fresh UUID on disk. A short retry_ssh wrapper rides out the ~minute of ssh banner-exchange flakiness right after each reboot, mirroring the pattern in the existing server_changes_at_runtime and pre_provisioned_uuid scenarios. The admin curl uses 127.0.0.1:adam.port (host-side docker port mapping) because adam.ip in the eden config is the EVE-side IP, not the host side. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
eriknordmark
added a commit
to lf-edge/eden
that referenced
this pull request
May 20, 2026
Picks up lf-edge/adam#155, which brings the /register handler in line with the eve-api spec (APIv2.md §/register, lines 134-160): cert/serial combinations that verify cryptographically but are not in the controller's pre-registration set now return 403 Forbidden rather than 401 Unauthorized. EVE's pkg/pillar/cmd/client already maps 403 to LedBlinkOnboardingFailureNotFound, so the longstanding eve-api gap on the controller side is now closed. Pinning a specific release rather than the rolling `snapshot` tag keeps the version requirement expressible — if a future eden change needs adam ≥ x.y.z, bumping the constant is the natural way to make that explicit, and stale cached `snapshot` images on contributor machines cannot silently regress. Override at config time remains supported via `eden config set default --key=adam.tag --value=<sha-or-tag>`. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/registerhandler currently returns 401 Unauthorized when theauth-container signature has already verified but the
(onboarding-cert, serial) combination is not in the controller's
pre-registration set. APIv2.md prescribes 403 Forbidden for that
case: "Valid credentials without authorization" (
/registertable)and lines 159-160 state the response "MUST" be 403 when the
controller requires pre-registration and a device tries to register
without one.
401 remains in
apiHandlerv2.registerfor the upstream cryptographicfailures: missing
SenderCertHash, malformed sender cert, signaturemismatch. The change here is confined to the post-auth authorization
decision in
registerProcess.EVE's
pkg/pillar/cmd/client/client.goalready maps 403 toLedBlinkOnboardingFailureNotFoundand carries anXXXcommentflagging that the controller side of the spec is not yet honoured;
this PR removes that gap. Older EVE that does not special-case 403
falls back to the generic "Registration failed" log path, same as
it does today for 401 — no regression.
Test plan
TestRegisterProcessForbiddenForUnknownCertinpkg/server/commonHandler_test.gocallsregisterProcessagainst an empty
memory.DeviceManagerand asserts a 403 status.go test ./pkg/server/ ./pkg/driver/... -count=1passes(
pkg/server,pkg/driver/file,pkg/driver/memory,pkg/driver/redis).server_returns_403in lf-edge/eden(
tests/onboarding/) verifies EVE raisesLedBlinkOnboardingFailureNotFoundwhen adam returns 403 foran unregistered onboarding cert. To be added once this PR lands.