nassh: prefs: drop old relay-host/relay-port migration

This code has been broken since it was added in 2013 -- it has a typo
when it tries to set the "relay-option" field (it's "relay-options")
which causes the code to fail.  Anyone hitting this code path probably
reinstalled the app to clear their prefs and thereby clear these.  So
drop the unused migration code.

Change-Id: I891d05058e59e327428a4e6c0952e765bcac0e21
Reviewed-on: https://chromium-review.googlesource.com/c/1352190
Reviewed-by: Vitaliy Shipitsyn <[email protected]>
Tested-by: Mike Frysinger <[email protected]>

Author: vapier

nassh/css/nassh_connect_dialog.css

@@ -155,7 +155,6 @@ a:hover {
 }
 
 #field-username,
-#field-relay-port,
 #field-port {
   max-width: 10em;
 }

nassh/js/nassh_preference_manager.js

@@ -79,16 +79,6 @@ nassh.ProfilePreferenceManager = function(parent, id) {
      */
     ['port', null],
 
-    /**
-     * The relay host, hardcoded to use nassh.GoogleRelay at the moment.
-     */
-    ['relay-host', ''],
-
-    /**
-     * The optional relay port.
-     */
-    ['relay-port', ''],
-
     /**
      * Options string for relay.
      * Supported values: --use-xhr and --use-ssl.
@@ -129,37 +119,3 @@ nassh.ProfilePreferenceManager = function(parent, id) {
 nassh.ProfilePreferenceManager.prototype =
     Object.create(lib.PreferenceManager.prototype);
 nassh.ProfilePreferenceManager.constructor = nassh.ProfilePreferenceManager;
-
-nassh.ProfilePreferenceManager.prototype.readStorage = function(opt_callback) {
-  var appendOption = (str) => {
-    var options = this.get('relay-options');
-    if (options) {
-      options += ' ' + str;
-    } else {
-      options = str;
-    }
-
-    this.set('relay-option', options);
-  };
-
-  var onRead = () => {
-    var host = this.get('relay-host');
-    if (host) {
-      console.warn('Merging relay-host preference with relay-options');
-      this.reset('relay-host');
-      appendOption('--proxy-host=' + host);
-    }
-
-    var port = this.get('relay-port');
-    if (port) {
-      this.reset('relay-port');
-      console.warn('Merging relay-host preference with relay-options');
-      appendOption('--proxy-port=' + port);
-    }
-
-    if (opt_callback)
-      opt_callback();
-  };
-
-  lib.PreferenceManager.prototype.readStorage.call(this, onRead);
-};