Add some basic pkg dependency docs for building on Debian/Ubuntu#133
Open
bpkroth wants to merge 2 commits into
Open
Add some basic pkg dependency docs for building on Debian/Ubuntu#133bpkroth wants to merge 2 commits into
bpkroth wants to merge 2 commits into
Conversation
Use a Debian-style host libdir on Debian/Ubuntu and keep lib64 as the fallback for Fedora-style systems. Codex: GPT-5 Signed-off-by: Brian Kroth <bpkroth@gmail.com>
mz-pdm
reviewed
Jun 9, 2026
mz-pdm
left a comment
mz-pdm
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me.
As for the AI attribution, I think it should be Assisted-by: Codex:GPT-5 (this is unclear in libkrun/AGENTS.md, it should be fixed there).
| SONAME_Windows = | ||
|
|
||
| LIBDIR_Linux = lib64 | ||
| LIBDIR_Linux = $(shell if [ -e /etc/debian_version ]; then printf 'lib/$(HOSTARCH)-linux-gnu'; else printf lib64; fi) |
Contributor
There was a problem hiding this comment.
Is there a particular reason why printf rather than echo?
| * Python 3 | ||
| * ```pyelftools``` (package ```python3-pyelftools``` in Fedora and Ubuntu) | ||
|
|
||
| On Debian/Ubuntu that's something like: |
Contributor
There was a problem hiding this comment.
The dependencies look correct to me, so "something like" could be dropped. Also note "Ubuntu" a few lines above, may be worth to adjust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some brief docs for build time dependencies on Debian/Ubuntu machines.
Also adjust the output directory to match something closer to their usual paths.