fix(gossipsub): remove duplicate config builder method

Noticed two methods which duplicated each other logic precisely, chose the one with more clear name, composed and improved the doc a tiny bit.

Pull-Request: #6173.

Author: skaunov

protocols/gossipsub/CHANGELOG.md

@@ -14,6 +14,9 @@
 - Fix incorrect default values in ConfigBuilder
   See [PR 6113](https://github.com/libp2p/rust-libp2p/pull/6113)
 
+- Remove duplicated config `set_topic_max_transmit_size` method, prefer `max_transmit_size_for_topic`.
+  See [PR 6173](https://github.com/libp2p/rust-libp2p/pull/6173).
+
 ## 0.49.2
 
 - Relax `Behaviour::with_metrics` requirements, do not require DataTransform and TopicSubscriptionFilter to also impl Default

protocols/gossipsub/src/behaviour/tests.rs

@@ -6471,7 +6471,7 @@ fn test_publish_message_with_default_transmit_size_config() {
     let topic_hash = topic.hash();
 
     let config = ConfigBuilder::default()
-        .set_topic_max_transmit_size(topic_hash.clone(), Config::default_max_transmit_size())
+        .max_transmit_size_for_topic(Config::default_max_transmit_size(), topic_hash.clone())
         .validation_mode(ValidationMode::Strict)
         .build()
         .unwrap();
@@ -6503,7 +6503,7 @@ fn test_publish_large_message_with_default_transmit_size_config() {
     let topic_hash = topic.hash();
 
     let config = ConfigBuilder::default()
-        .set_topic_max_transmit_size(topic_hash.clone(), Config::default_max_transmit_size())
+        .max_transmit_size_for_topic(Config::default_max_transmit_size(), topic_hash.clone())
         .validation_mode(ValidationMode::Strict)
         .build()
         .unwrap();
@@ -6531,7 +6531,7 @@ fn test_publish_message_with_specific_transmit_size_config() {
 
     let max_topic_transmit_size = 2000;
     let config = ConfigBuilder::default()
-        .set_topic_max_transmit_size(topic_hash.clone(), max_topic_transmit_size)
+        .max_transmit_size_for_topic(max_topic_transmit_size, topic_hash.clone())
         .validation_mode(ValidationMode::Strict)
         .build()
         .unwrap();
@@ -6564,7 +6564,7 @@ fn test_publish_large_message_with_specific_transmit_size_config() {
 
     let max_topic_transmit_size = 2048;
     let config = ConfigBuilder::default()
-        .set_topic_max_transmit_size(topic_hash.clone(), max_topic_transmit_size)
+        .max_transmit_size_for_topic(max_topic_transmit_size, topic_hash.clone())
         .validation_mode(ValidationMode::Strict)
         .build()
         .unwrap();
@@ -6592,7 +6592,7 @@ fn test_validation_error_message_size_too_large_topic_specific() {
     let max_size = 2048;
 
     let config = ConfigBuilder::default()
-        .set_topic_max_transmit_size(topic_hash.clone(), max_size)
+        .max_transmit_size_for_topic(max_size, topic_hash.clone())
         .validation_mode(ValidationMode::None)
         .build()
         .unwrap();
@@ -6696,7 +6696,7 @@ fn test_validation_message_size_within_topic_specific() {
     let max_size = 2048;
 
     let config = ConfigBuilder::default()
-        .set_topic_max_transmit_size(topic_hash.clone(), max_size)
+        .max_transmit_size_for_topic(max_size, topic_hash.clone())
         .validation_mode(ValidationMode::None)
         .build()
         .unwrap();

protocols/gossipsub/src/config.rs

@@ -1075,15 +1075,6 @@ impl ConfigBuilder {
         self
     }
 
-    /// The topic max size sets message sizes for a given topic.
-    pub fn set_topic_max_transmit_size(&mut self, topic: TopicHash, max_size: usize) -> &mut Self {
-        self.config
-            .protocol
-            .max_transmit_sizes
-            .insert(topic, max_size);
-        self
-    }
-
     /// Constructs a [`Config`] from the given configuration and validates the settings.
     pub fn build(&self) -> Result<Config, ConfigBuilderError> {
         // check all constraints on config