Skip to content

Commit dda4c5c

Browse files
committed
Channel logging improvements
Additional trace logs to help with debugging.
1 parent a873775 commit dda4c5c

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

lightning/src/ln/channel.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8899,8 +8899,8 @@ where
88998899
);
89008900
return_with_htlcs_to_fail!(htlcs_to_fail);
89018901
} else {
8902-
log_debug!(logger, "Received a valid revoke_and_ack with no reply necessary. {} monitor update.",
8903-
release_state_str);
8902+
log_debug!(logger, "Received a valid revoke_and_ack with no reply necessary. {} monitor update {}.",
8903+
release_state_str, monitor_update.update_id);
89048904

89058905
self.monitor_updating_paused(
89068906
false,

lightning/src/ln/channelmanager.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9418,6 +9418,9 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
94189418
for action in actions.into_iter() {
94199419
match action {
94209420
MonitorUpdateCompletionAction::PaymentClaimed { payment_hash, pending_mpp_claim } => {
9421+
let logger = WithContext::from(&self.logger, None, None, Some(payment_hash));
9422+
log_trace!(logger, "Handling PaymentClaimed monitor update completion action");
9423+
94219424
if let Some((counterparty_node_id, chan_id, claim_ptr)) = pending_mpp_claim {
94229425
let per_peer_state = self.per_peer_state.read().unwrap();
94239426
per_peer_state.get(&counterparty_node_id).map(|peer_state_mutex| {
@@ -9493,6 +9496,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
94939496
// `payment_id` should suffice to ensure we never spuriously drop a second
94949497
// event for a duplicate payment.
94959498
if !pending_events.contains(&event_action) {
9499+
log_trace!(self.logger, "Queuing PaymentClaimed event with event completion action {:?}", event_action.1);
94969500
pending_events.push_back(event_action);
94979501
}
94989502
}
@@ -17032,10 +17036,6 @@ where
1703217036

1703317037
let logger = WithChannelMonitor::from(&args.logger, monitor, None);
1703417038
let channel_id = monitor.channel_id();
17035-
log_info!(
17036-
logger,
17037-
"Queueing monitor update to ensure missing channel is force closed",
17038-
);
1703917039
let monitor_update = ChannelMonitorUpdate {
1704017040
update_id: monitor.get_latest_update_id().saturating_add(1),
1704117041
updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed {
@@ -17044,6 +17044,11 @@ where
1704417044
channel_id: Some(monitor.channel_id()),
1704517045
encoded_channel: Some(Vec::new()),
1704617046
};
17047+
log_info!(
17048+
logger,
17049+
"Queueing monitor update {} to ensure missing channel is force closed",
17050+
monitor_update.update_id
17051+
);
1704717052
let funding_txo = monitor.get_funding_txo();
1704817053
let update = BackgroundEvent::MonitorUpdateRegeneratedOnStartup {
1704917054
counterparty_node_id,

0 commit comments

Comments
 (0)