Skip to content

Conversation

@TheBlueMatt
Copy link
Collaborator

Various fields in ChannelDetails refer to channel information which changes on splice, which we ensure is consistently documented here.

Various fields in `ChannelDetails` refer to channel information
which changes on splice, which we ensure is consistently documented
here.
@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Dec 1, 2025
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 1, 2025

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (fe5d942) to head (c3cc331).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4250   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         180      180           
  Lines      138730   138730           
  Branches   138730   138730           
=======================================
+ Hits       123914   123922    +8     
+ Misses      12190    12184    -6     
+ Partials     2626     2624    -2     
Flag Coverage Δ
fuzzing 35.02% <ø> (ø)
tests 88.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt TheBlueMatt merged commit ad8ce97 into lightningdevkit:main Dec 1, 2025
26 checks passed
@tnull
Copy link
Contributor

tnull commented Dec 1, 2025

Now adopted for LDK Node's variant of ChannelDetails over at lightningdevkit/ldk-node#721

@TheBlueMatt TheBlueMatt mentioned this pull request Dec 2, 2025
@TheBlueMatt
Copy link
Collaborator Author

Backported in #4254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants