Skip to content

Commit f8a2cf0

Browse files
Merge pull request #293 from marckleinebudde/misc-cleanups
Misc cleanups
2 parents 553f0d2 + b88a64e commit f8a2cf0

File tree

2 files changed

+25
-12
lines changed

2 files changed

+25
-12
lines changed

canfdtest.c

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ static void print_usage(char *prg)
5858
"Usage: %s [options] <can-interface>\n"
5959
"\n"
6060
"Options:\n"
61-
" -v (low verbosity)\n"
62-
" -vv (high verbosity)\n"
61+
" -f COUNT (number of frames in flight, default: %d)\n"
6362
" -g (generate messages)\n"
6463
" -l COUNT (test loop count)\n"
65-
" -f COUNT (number of frames in flight, default: %d)\n"
64+
" -v (low verbosity)\n"
65+
" -vv (high verbosity)\n"
6666
"\n"
6767
"With the option '-g' CAN messages are generated and checked\n"
6868
"on <can-interface>, otherwise all messages received on the\n"
@@ -376,21 +376,22 @@ int main(int argc, char *argv[])
376376

377377
while ((opt = getopt(argc, argv, "f:gl:v?")) != -1) {
378378
switch (opt) {
379-
case 'v':
380-
verbose++;
381-
break;
382379
case 'f':
383380
inflight_count = atoi(optarg);
384381
break;
385382

383+
case 'g':
384+
echo_gen = 1;
385+
break;
386+
386387
case 'l':
387388
test_loops = atoi(optarg);
388389
break;
389390

390-
case 'g':
391-
echo_gen = 1;
391+
case 'v':
392+
verbose++;
392393
break;
393-
394+
394395
case '?':
395396
default:
396397
print_usage(basename(argv[0]));

slcan_attach.c

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,18 @@ void print_usage(char *prg)
6969
fprintf(stderr, " -d (only detach line discipline)\n");
7070
fprintf(stderr, " -w (attach - wait for keypess - detach)\n");
7171
fprintf(stderr, " -n <name> (assign created netdevice name)\n");
72+
fprintf(stderr, "\n"
73+
" <speed> Bitrate\n"
74+
" 0 10 Kbit/s\n"
75+
" 1 20 Kbit/s\n"
76+
" 2 50 Kbit/s\n"
77+
" 3 100 Kbit/s\n"
78+
" 4 125 Kbit/s\n"
79+
" 5 250 Kbit/s\n"
80+
" 6 500 Kbit/s\n"
81+
" 7 800 Kbit/s\n"
82+
" 8 1000 Kbit/s\n"
83+
"\n");
7284
fprintf(stderr, "\nExamples:\n");
7385
fprintf(stderr, "slcan_attach -w -o -f -s6 -c /dev/ttyS1\n\n");
7486
fprintf(stderr, "slcan_attach /dev/ttyS1\n\n");
@@ -213,7 +225,7 @@ int main(int argc, char **argv)
213225
/* try to rename the created device if requested */
214226
if (name) {
215227
int s = socket(PF_INET, SOCK_DGRAM, 0);
216-
228+
217229
printf("rename netdevice %s to %s ... ", buf, name);
218230

219231
if (s < 0)
@@ -222,12 +234,12 @@ int main(int argc, char **argv)
222234
/* current slcan%d name is still in ifr.ifr_name */
223235
memset (ifr.ifr_newname, 0, sizeof(ifr.ifr_newname));
224236
strncpy (ifr.ifr_newname, name, sizeof(ifr.ifr_newname) - 1);
225-
237+
226238
if (ioctl(s, SIOCSIFNAME, &ifr) < 0)
227239
printf("failed!\n");
228240
else
229241
printf("ok.\n");
230-
242+
231243
close(s);
232244
}
233245
}

0 commit comments

Comments
 (0)