Skip to content

Conversation

@lukaszgryglicki
Copy link
Member

cc @mlehotskylf @ahmedomosanya

Signed-off-by: Lukasz Gryglicki [email protected]

Assisted by OpenAI

Assisted by GitHub Copilot

@lukaszgryglicki lukaszgryglicki self-assigned this Nov 19, 2025
Copilot AI review requested due to automatic review settings November 19, 2025 07:02
@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch unicron-4862-use-only-newer-fivetran-sync-dates-prod

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds logic to skip using Fivetran synced dates that are on or before March 9, 2024, likely due to data quality concerns with older Fivetran data in the signature timestamp backfill process.

Key changes:

  • Introduced a cutoff date constant for filtering unreliable Fivetran data
  • Added validation logic to check if Fivetran timestamps fall before the cutoff
  • Modified the snowflakeFix function to skip Fivetran data when timestamps are too old

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lukaszgryglicki lukaszgryglicki merged commit 77a2191 into main Nov 19, 2025
10 of 11 checks passed
@lukaszgryglicki lukaszgryglicki deleted the unicron-4862-use-only-newer-fivetran-sync-dates-prod branch November 19, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants