-
Notifications
You must be signed in to change notification settings - Fork 23
feat: leaderboard collection filter #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
Signed-off-by: Gašper Grom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a collection filter feature to the leaderboard pages, allowing users to filter leaderboard data by specific collections. The implementation includes a new dropdown filter component with search functionality, backend API support for the collection filter, and an empty state UI for when no results are found.
Key Changes:
- Added
collectionSlugquery parameter to leaderboard API endpoints for filtering by collection - Implemented a new
LfxCollectionsFiltercomponent with searchable dropdown functionality - Added
searchparameter support to the collection API endpoint - Introduced empty state UI in leaderboard detail view with appropriate messaging
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/server/api/leaderboard/[type].ts |
Added collectionSlug query parameter to filter leaderboard results by collection |
frontend/server/api/collection/index.ts |
Added search query parameter to enable collection searching |
frontend/app/components/modules/leaderboards/services/leaderboard.api.service.ts |
Updated query keys and parameters to include collectionSlug for proper cache management |
frontend/app/components/modules/leaderboards/components/views/leaderboard-detail.vue |
Integrated collection filter, added empty state UI, and adjusted layout styling |
frontend/app/components/modules/leaderboards/components/sections/leaderboard-detail-header.vue |
Restructured header layout to accommodate collection filter component in both desktop and mobile views |
frontend/app/components/modules/leaderboards/components/filters/collections-filter.vue |
New component providing searchable dropdown for collection selection |
frontend/app/components/modules/collection/services/collections.api.service.ts |
Added searchCollections method to fetch collections with search filtering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/app/components/modules/leaderboards/components/views/leaderboard-detail.vue
Show resolved
Hide resolved
frontend/app/components/modules/leaderboards/components/filters/collections-filter.vue
Show resolved
Hide resolved
Signed-off-by: Gašper Grom <[email protected]>
No description provided.