Skip admin email prompt when using new platform activation flow (#3385)

* Skip admin email prompt when using new platform activation flow

Author: nprokopic

cmd/vclusterctl/cmd/platform/start.go

@@ -86,7 +86,7 @@ before running this command:
 }
 
 func (cmd *StartCmd) Run(ctx context.Context) error {
-	// get version to deploy
+	// get the version to deploy
 	if cmd.Version == "latest" || cmd.Version == "" {
 		cmd.Version = platform.MinimumVersionTag
 		latestVersion, err := platform.LatestCompatibleVersion(ctx)
@@ -154,8 +154,10 @@ func (cmd *StartCmd) Run(ctx context.Context) error {
 		}
 	}
 
-	if err := cmd.ensureEmailWithDisclaimer(ctx, cmd.KubeClient, cmd.Namespace); err != nil {
-		return err
+	if !cmd.platformUsesNewActivationFlow(cmd.Version) {
+		if err := cmd.ensureEmailWithDisclaimer(ctx, cmd.KubeClient, cmd.Namespace); err != nil {
+			return err
+		}
 	}
 
 	return start.NewLoftStarter(cmd.StartOptions).Start(ctx)
@@ -192,6 +194,39 @@ Privacy Statement: https://www.loft.sh/legal/privacy
 	return nil
 }
 
+// platformUsesNewActivationFlow checks if the platform version supports the new platform activation flow.
+//
+// The new platform activation flow is supported for the following platform versions:
+//  1. GA version >= 4.6.0,
+//  2. Preview version 4.6.0-next.internal.X, where X >= 1.
+func (cmd *StartCmd) platformUsesNewActivationFlow(platformVersion string) bool {
+	platformSemVerVersion, err := semver.ParseTolerant(platformVersion)
+	if err != nil {
+		cmd.Log.Warnf("Failed to parse platform version %s, falling back to the old platform activation flow with the admin email prompt", platformVersion)
+		return false
+	}
+
+	const minGAVersion = "4.6.0"
+	if platformSemVerVersion.GTE(semver.MustParse(minGAVersion)) {
+		cmd.Log.Debugf("Platform version %s is greater than or equal to %s, platform is using the new activation flow, so skipping admin email prompt", platformVersion, minGAVersion)
+		return true
+	}
+
+	if platformSemVerVersion.Major == 4 &&
+		platformSemVerVersion.Minor == 6 &&
+		platformSemVerVersion.Patch == 0 &&
+		len(platformSemVerVersion.Pre) == 3 &&
+		platformSemVerVersion.Pre[0].VersionStr == "next" &&
+		platformSemVerVersion.Pre[1].VersionStr == "internal" &&
+		platformSemVerVersion.Pre[2].VersionNum >= 1 {
+		cmd.Log.Debugf("Platform version %s is the development version that is using the new activation flow, so skipping admin email prompt", platformVersion)
+		return true
+	}
+
+	cmd.Log.Debugf("Platform version %s is not using the new activation flow, so admin email is required", platformVersion)
+	return false
+}
+
 func promptForEmail(emailAddress string) (string, error) {
 	if err := validateEmail(emailAddress); err != nil {
 		return survey.NewSurvey().Question(&survey.QuestionOptions{

cmd/vclusterctl/cmd/platform/start_test.go

@@ -0,0 +1,47 @@
+package platform
+
+import (
+	"testing"
+
+	"github.com/loft-sh/log"
+	"github.com/loft-sh/vcluster/pkg/cli/flags"
+	"github.com/loft-sh/vcluster/pkg/cli/start"
+)
+
+func TestPlatformUsesNewActivationFlow(t *testing.T) {
+	testCases := []struct {
+		version  string
+		expected bool
+	}{
+		{"", false},
+		{"dev", false},
+		{"4.5.0", false},
+		{"v4.5.0", false},
+		{"4.5.1", false},
+		{"4.6.0-alpha.5", false},
+		{"4.6.0-next.2", false},
+		{"4.6.0-next.internal.0", false},
+		{"4.6.0-next.internal.1", true},
+		{"4.6.0-next.internal.2", true},
+		{"4.6.0", true},
+		{"v4.6.0", true},
+	}
+
+	globalFlags := &flags.GlobalFlags{}
+	startCmd := &StartCmd{
+		StartOptions: start.StartOptions{
+			Options: start.Options{
+				CommandName: "start",
+				GlobalFlags: globalFlags,
+				Log:         log.GetInstance(),
+			},
+		},
+	}
+
+	for _, testCase := range testCases {
+		result := startCmd.platformUsesNewActivationFlow(testCase.version)
+		if result != testCase.expected {
+			t.Errorf("Expected %v, got %v for platform version %s", testCase.expected, result, testCase.version)
+		}
+	}
+}