address review comments

Author: chaitanyaprem

apps/chat2mix/chat2mix.nim

@@ -124,7 +124,7 @@ proc encode*(message: Chat2Message): ProtoBuffer =
 
   return serialised
 
-proc toString*(message: Chat2Message): string =
+proc `$`*(message: Chat2Message): string =
   # Get message date and timestamp in local time
   let time = message.timestamp.fromUnix().local().format("'<'MMM' 'dd,' 'HH:mm'>'")
 
@@ -150,7 +150,7 @@ proc getChatLine(payload: seq[byte]): string =
   # No payload encoding/encryption from Waku
   let pb = Chat2Message.init(payload).valueOr:
     return string.fromBytes(payload)
-  return pb.toString()
+  return $pb
 
 proc printReceivedMessage(c: Chat, msg: WakuMessage) =
   let chatLine = getChatLine(msg.payload)

waku/node/waku_node.nim

@@ -22,6 +22,7 @@ import
   libp2p/transports/tcptransport,
   libp2p/transports/wstransport,
   libp2p/utility,
+  libp2p/utils/offsettedseq,
   libp2p/protocols/mix,
   libp2p/protocols/mix/mix_protocol
 

waku/waku_mix/protocol.nim

@@ -182,11 +182,11 @@ proc new*(
     peermgr.switch.peerInfo.publicKey.skkey, peermgr.switch.peerInfo.privateKey.skkey,
   )
   if bootnodes.len < mixMixPoolSize:
-    warn "publishing with mix won't work until atleast 3 mix nodes in node pool"
+    warn "publishing with mix won't work until there are 3 mix nodes in node pool"
   let initTable = processBootNodes(bootnodes, peermgr)
 
   if len(initTable) < mixMixPoolSize:
-    warn "publishing with mix won't work until atleast  3 mix nodes in node pool"
+    warn "publishing with mix won't work until there are 3 mix nodes in node pool"
   var m = WakuMix(peerManager: peermgr, clusterId: clusterId, pubKey: mixPubKey)
   procCall MixProtocol(m).init(localMixNodeInfo, initTable, peermgr.switch)
   return ok(m)

waku/waku_rendezvous/protocol.nim

@@ -26,12 +26,6 @@ import
   ./common,
   ./waku_peer_record
 
-# Explicitly make the items iterator visible in this module's scope
-# This is needed for generic instantiation of rendezvous methods
-iterator items*[T](o: OffsettedSeq[T]): T =
-  for item in offsettedseq.items(o):
-    yield item
-
 logScope:
   topics = "waku rendezvous"