Skip to content

Commit 35a017e

Browse files
update again
1 parent 0bafaa0 commit 35a017e

File tree

3 files changed

+37
-37
lines changed

3 files changed

+37
-37
lines changed

.github/ISSUE_TEMPLATE/prepare_beta_release.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: Prepare Beta Release
3-
about: Execute tasks for the creation and publishing of a new beta release.
3+
about: Execute tasks for the creation and publishing of a new beta release
44
title: 'Prepare beta release 0.0.0'
55
labels: beta-release
66
assignees: ''
@@ -17,13 +17,13 @@ For detailed info on the release process refer to https://github.com/waku-org/nw
1717

1818
All items below are to be completed by the owner of the given release.
1919

20-
- [ ] Create release branch ( e.g. release/v0.X.0-beta ) if it doesn't exist.
21-
- [ ] Assign release candidate tag to the release branch HEAD. e.g. v0.X.0-beta-rc.0, v0.X.0-beta-rc.1, ... v0.X.0-beta-rc.N etc.
20+
- [ ] Create release branch (e.g. `release/v0.X.0-beta`) if it doesn't exist.
21+
- [ ] Assign release candidate tag to the release branch HEAD (e.g. `v0.X.0-beta-rc.0`, `v0.X.0-beta-rc.1`, ... `v0.X.0-beta-rc.N`).
2222
- [ ] Generate and edit release notes in CHANGELOG.md.
2323

2424
- [ ] **Waku test and fleets validation**
2525
- [ ] Ensure all the unit tests (specifically js-waku tests) are green against the release candidate.
26-
- [ ] Deploy the release candidate to `waku.test` only through [deploy-waku-test job](https://ci.infra.status.im/job/nim-waku/job/deploy-waku-test/) and wait for it to finish (Jenkins access required; ask the infra team if you don't have it.).
26+
- [ ] Deploy the release candidate to `waku.test` only through [deploy-waku-test job](https://ci.infra.status.im/job/nim-waku/job/deploy-waku-test/) and wait for it to finish (Jenkins access required; ask the infra team if you don't have it).
2727
- After completion, disable [deployment job](https://ci.infra.status.im/job/nim-waku/) so that its version is not updated on every merge to master.
2828
- Verify the deployed version at https://fleets.waku.org/.
2929
- Confirm the container image exists on [Harbor](https://harbor.status.im/harbor/projects/9/repositories/nwaku/artifacts-tab).
@@ -33,14 +33,14 @@ All items below are to be completed by the owner of the given release.
3333

3434
- [ ] **Proceed with release**
3535

36-
- [ ] Assign a final release tag ( v0.X.0-beta ) to the same commit that contains the validated release-candidate tag (e.g. v0.X.0-beta-rc.N) and submit a PR from the release branch to master.
36+
- [ ] Assign a final release tag (`v0.X.0-beta`) to the same commit that contains the validated release-candidate tag (e.g. `v0.X.0-beta-rc.N`) and submit a PR from the release branch to `master`.
3737
- [ ] Update [nwaku-compose](https://github.com/waku-org/nwaku-compose) and [waku-simulator](https://github.com/waku-org/waku-simulator) according to the new release.
3838
- [ ] Bump nwaku dependency in [waku-rust-bindings](https://github.com/waku-org/waku-rust-bindings) and make sure all examples and tests work.
3939
- [ ] Bump nwaku dependency in [waku-go-bindings](https://github.com/waku-org/waku-go-bindings) and make sure all tests work.
4040
- [ ] Create GitHub release (https://github.com/waku-org/nwaku/releases).
41-
- [ ] Submit a PR to merge the release branch back to `master`. Make sure you use the option `Merge pull request (Create a merge commit)` to perform such merge. Ping repo admin if this option is not available.
41+
- [ ] Submit a PR to merge the release branch back to `master`. Make sure you use the option "Merge pull request (Create a merge commit)" to perform the merge. Ping repo admin if this option is not available.
4242

43-
- [ ] **Promote release to fleets**.
43+
- [ ] **Promote release to fleets**
4444
- [ ] Ask the PM lead to announce the release.
4545
- [ ] Update infra config with any deprecated arguments or changed options.
4646

.github/ISSUE_TEMPLATE/prepare_full_release.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,26 @@ For detailed info on the release process refer to https://github.com/waku-org/nw
1717

1818
All items below are to be completed by the owner of the given release.
1919

20-
- [ ] Create release branch ( e.g. release/v0.X.0-beta ) if it doesn't exist.
21-
- [ ] Assign release candidate tag to the release branch HEAD. e.g. v0.X.0-beta-rc.0, v0.X.0-beta-rc.1, ... v0.X.0-beta-rc.N etc.
22-
- [ ] Generate and edit release notes in CHANGELOG.md
20+
- [ ] Create release branch (e.g. `release/v0.X.0`) if it doesn't exist.
21+
- [ ] Assign release candidate tag to the release branch HEAD (e.g. `v0.X.0-rc.0`, `v0.X.0-rc.1`, ... `v0.X.0-rc.N`).
22+
- [ ] Generate and edit release notes in CHANGELOG.md.
2323

2424
- [ ] **Validation of release candidate**
2525

2626
- [ ] **Automated testing**
2727
- [ ] Ensure all the unit tests (specifically js-waku tests) are green against the release candidate.
28-
- [ ] Ask Vac-QA and Vac-DST to perform the available tests against the release candidate
28+
- [ ] Ask Vac-QA and Vac-DST to perform the available tests against the release candidate.
2929
- [ ] Vac-DST (an additional report is needed; see [this](https://www.notion.so/DST-Reports-1228f96fb65c80729cd1d98a7496fe6f))
3030

3131
- [ ] **Waku fleet testing**
3232
- [ ] Deploy the release candidate to `waku.test` and `waku.sandbox` fleets.
3333
- Start the [deployment job](https://ci.infra.status.im/job/nim-waku/) for both fleets and wait for it to finish (Jenkins access required; ask the infra team if you don't have it).
34-
- After completion, disable [deployment job](https://ci.infra.status.im/job/nim-waku/) so that its version is not updated on every merge to master
34+
- After completion, disable [deployment job](https://ci.infra.status.im/job/nim-waku/) so that its version is not updated on every merge to `master`.
3535
- Verify the deployed version at https://fleets.waku.org/.
3636
- Confirm the container image exists on [Harbor](https://harbor.status.im/harbor/projects/9/repositories/nwaku/artifacts-tab).
3737
- [ ] Search _Kibana_ logs from the previous month (since the last release was deployed) for possible crashes or errors in `waku.test` and `waku.sandbox`.
3838
- Most relevant logs are `(fleet: "waku.test" AND message: "SIGSEGV")` OR `(fleet: "waku.sandbox" AND message: "SIGSEGV")`.
39-
- [ ] Enable again the `waku.test` fleet to resume auto-deployment of the latest `master` commit
39+
- [ ] Enable again the `waku.test` fleet to resume auto-deployment of the latest `master` commit.
4040

4141
- [ ] **Status fleet testing**
4242
- [ ] Deploy release candidate to `status.staging`
@@ -54,15 +54,15 @@ All items below are to be completed by the owner of the given release.
5454

5555
- [ ] **Proceed with release**
5656

57-
- [ ] Assign a final release tag ( v0.X.0 ) to the same commit that contains the validated release-candidate tag (e.g. v0.X.0-beta)
57+
- [ ] Assign a final release tag (`v0.X.0`) to the same commit that contains the validated release-candidate tag (e.g. `v0.X.0-rc.N`).
5858
- [ ] Update [nwaku-compose](https://github.com/waku-org/nwaku-compose) and [waku-simulator](https://github.com/waku-org/waku-simulator) according to the new release.
5959
- [ ] Bump nwaku dependency in [waku-rust-bindings](https://github.com/waku-org/waku-rust-bindings) and make sure all examples and tests work.
6060
- [ ] Bump nwaku dependency in [waku-go-bindings](https://github.com/waku-org/waku-go-bindings) and make sure all tests work.
61-
- [ ] Create GitHub release (https://github.com/waku-org/nwaku/releases)
62-
- [ ] Submit a PR to merge the release branch back to `master`. Make sure you use the option `Merge pull request (Create a merge commit)` to perform such merge. Ping repo admin if this option is not available.
61+
- [ ] Create GitHub release (https://github.com/waku-org/nwaku/releases).
62+
- [ ] Submit a PR to merge the release branch back to `master`. Make sure you use the option "Merge pull request (Create a merge commit)" to perform the merge. Ping repo admin if this option is not available.
6363

64-
- [ ] **Promote release to fleets**.
65-
- [ ] Ask for release announcement to PM lead.
64+
- [ ] **Promote release to fleets**
65+
- [ ] Ask the PM lead to announce the release.
6666
- [ ] Update infra config with any deprecated arguments or changed options.
6767

6868
### Links
@@ -72,5 +72,5 @@ All items below are to be completed by the owner of the given release.
7272
- [Fleet ownership](https://www.notion.so/Fleet-Ownership-7532aad8896d46599abac3c274189741?pvs=4#d2d2f0fe4b3c429fbd860a1d64f89a64)
7373
- [Infra-nim-waku](https://github.com/status-im/infra-nim-waku)
7474
- [Jenkins](https://ci.infra.status.im/job/nim-waku/)
75-
- [Fleet](https://fleets.waku.org/)
75+
- [Fleets](https://fleets.waku.org/)
7676
- [Harbor](https://harbor.status.im/harbor/projects/9/repositories/nwaku/artifacts-tab)

docs/contributors/release-process.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ For more context, see https://trunkbaseddevelopment.com/branch-for-release/
2222

2323
- **Beta release**: skip just `6a` and `6c` steps from [Release process](#release-process--step-by-step).
2424

25-
- choose the appropriate release process based on the release type.
26-
[Full Release](../../.github/ISSUE_TEMPLATE/prepare_full_release.md),
27-
[Beta Release](../../.github/ISSUE_TEMPLATE/prepare_beta_release.md)
25+
- Choose the appropriate release process based on the release type:
26+
- [Full Release](../../.github/ISSUE_TEMPLATE/prepare_full_release.md)
27+
- [Beta Release](../../.github/ISSUE_TEMPLATE/prepare_beta_release.md)
2828

2929
### Release process ( step by step )
3030

@@ -70,39 +70,39 @@ For more context, see https://trunkbaseddevelopment.com/branch-for-release/
7070
7171
6a. **Automated testing**
7272
- Ensure all the unit tests (specifically js-waku tests) are green against the release candidate.
73-
- Ask Vac-QA and Vac-DST to run their available tests against the release candidate, share all release candidate with both team.
73+
- Ask Vac-QA and Vac-DST to run their available tests against the release candidate; share all release candidates with both teams.
7474
75-
> We need additional report like [this](https://www.notion.so/DST-Reports-1228f96fb65c80729cd1d98a7496fe6f) specificly from DST team.
75+
> We need an additional report like [this](https://www.notion.so/DST-Reports-1228f96fb65c80729cd1d98a7496fe6f) specifically from the DST team.
7676
7777
6b. **Waku fleet testing**
78-
- Start job on `waku.sandbox` and `waku.test` [ Deployment job ](https://ci.infra.status.im/job/nim-waku/), Wait for completion of the job. If it fails, then debug it.
79-
- After completion, disable [deployment job](https://ci.infra.status.im/job/nim-waku/) so that its version is not updated on every merge to master.
78+
- Start job on `waku.sandbox` and `waku.test` [Deployment job](https://ci.infra.status.im/job/nim-waku/), wait for completion of the job. If it fails, then debug it.
79+
- After completion, disable [deployment job](https://ci.infra.status.im/job/nim-waku/) so that its version is not updated on every merge to `master`.
8080
- Verify at https://fleets.waku.org/ that the fleet is locked to the release candidate version.
81-
- Check if the image is created at [harbor](https://harbor.status.im/harbor/projects/9/repositories/nwaku/artifacts-tab).
81+
- Check if the image is created at [Harbor](https://harbor.status.im/harbor/projects/9/repositories/nwaku/artifacts-tab).
8282
- Search _Kibana_ logs from the previous month (since the last release was deployed) for possible crashes or errors in `waku.test` and `waku.sandbox`.
8383
- Most relevant logs are `(fleet: "waku.test" AND message: "SIGSEGV")` OR `(fleet: "waku.sandbox" AND message: "SIGSEGV")`.
84-
- Enable again the `waku.test` fleet to resume auto-deployment of the latest `master` commit
84+
- Enable the `waku.test` fleet again to resume auto-deployment of the latest `master` commit.
8585
8686
6c. **Status fleet testing**
8787
- Deploy release candidate to `status.staging`
8888
- Perform [sanity check](https://www.notion.so/How-to-test-Nwaku-on-Status-12c6e4b9bf06420ca868bd199129b425) and log results as comments in this issue.
8989
- Connect 2 instances to `status.staging` fleet, one in relay mode, the other one in light client.
90-
- 1:1 chats with each other
90+
- 1:1 Chats with each other
9191
- Send and receive messages in a community
9292
- Close one instance, send messages with second instance, reopen first instance and confirm messages sent while offline are retrieved from store
93-
- Perform checks based on _end-user impact_
94-
- Inform other (Waku and Status) CCs to point their instance to `status.staging` for a few days. Ping Status colleagues from their Discord server or [Status community](https://status.app) (not blocking point.)
95-
- Ask Status-QA to perform sanity checks (as described above) + checks based on _end user impact_; do specify the version being tested
96-
- Ask Status-QA or infra to run the automated Status e2e tests against `status.staging`
97-
- Get other CCs sign-off: they comment on this PR "used app for a week, no problem", or problem reported, resolved and new RC
98-
- **Get Status-QA sign-off**. Ensuring that `status.test` update will not disturb ongoing activities.
93+
- Perform checks based on _end-user impact_.
94+
- Inform other (Waku and Status) CCs to point their instances to `status.staging` for a few days. Ping Status colleagues from their Discord server or [Status community](https://status.app) (not a blocking point).
95+
- Ask Status-QA to perform sanity checks (as described above) and checks based on _end user impact_; specify the version being tested.
96+
- Ask Status-QA or infra to run the automated Status e2e tests against `status.staging`.
97+
- Get other CCs' sign-off: they should comment on this PR, e.g., "Used the app for a week, no problem." If problems are reported, resolve them and create a new RC.
98+
- **Get Status-QA sign-off**, ensuring that the `status.test` update will not disturb ongoing activities.
9999
100100
7. Once the release-candidate has been validated, create a final release tag and push it.
101101
We also need to merge the release branch back into master as a final step.
102102
103103
```
104104
git checkout release/v0.X.0
105-
git tag -as v0.X.0 -m "final release." ( use v0.X.0-beta as the tag if you are creating a beta release)
105+
git tag -as v0.X.0 -m "final release." (use v0.X.0-beta as the tag if you are creating a beta release)
106106
git push origin v0.X.0
107107
git switch master
108108
git pull
@@ -153,5 +153,5 @@ We also need to merge the release branch back into master as a final step.
153153
- [Fleet ownership](https://www.notion.so/Fleet-Ownership-7532aad8896d46599abac3c274189741?pvs=4#d2d2f0fe4b3c429fbd860a1d64f89a64)
154154
- [Infra-nim-waku](https://github.com/status-im/infra-nim-waku)
155155
- [Jenkins](https://ci.infra.status.im/job/nim-waku/)
156-
- [Fleet](https://fleets.waku.org/)
156+
- [Fleets](https://fleets.waku.org/)
157157
- [Harbor](https://harbor.status.im/harbor/projects/9/repositories/nwaku/artifacts-tab)

0 commit comments

Comments
 (0)