Highlight drivers with anomalously newer dates in UI

Author: lostindark

Rapr/DSEForm.cs

@@ -33,6 +33,8 @@ public partial class DSEForm : Form
         private Color savedBackColor;
         private Color savedForeColor;
 
+        private HashSet<DriverStoreEntry> driversWithNewerDate = new HashSet<DriverStoreEntry>();
+
         private static readonly IUpdateManager UpdateManager = new UpdateManager();
 
         private static readonly ICollection<CultureInfo> SupportedLanguage = DSEFormHelper.GetSupportedLanguage();
@@ -336,6 +338,7 @@ private async Task PopulateUIWithDriverStoreEntries()
                 this.ShowStatus(Status.Normal, Language.Message_Scanning_Driver_Store);
                 this.lstDriverStoreEntries.EmptyListMsg = Language.Message_Scanning_Driver_Store;
                 this.lstDriverStoreEntries.ClearObjects();
+                this.driversWithNewerDate.Clear();
 
                 var driverStoreEntries = await Task.Run(() => this.driverStore.EnumeratePackages()).ConfigureAwait(true);
                 this.lstDriverStoreEntries.SetObjects(driverStoreEntries);
@@ -804,18 +807,39 @@ private void CtxMenuSelectOldDrivers_Click(object sender, EventArgs e)
                     queryEntries = queryEntries.Where(entry => entry.BootCritical != true);
                 }
 
-                var oldDriversToSelect = queryEntries
+                var driverGroups = queryEntries
                     .Where(entry => entry.DriverInfName != "ntprint.inf")
                     .GroupBy(entry => new { entry.DriverClass, entry.DriverExtensionId, entry.DriverPkgProvider, entry.DriverInfName })
-                    .SelectMany(drivers => drivers
+                    .Select(drivers => drivers
                         .GroupBy(entry => new { entry.DriverVersion, entry.DriverDate })
                         .OrderByDescending(g => g.Key.DriverVersion)
                         .ThenByDescending(g => g.Key.DriverDate)
+                        .ToList())
+                    .Where(groups => groups.Count > 1)
+                    .ToList();
+
+                var oldDriversToSelect = driverGroups
+                    .SelectMany(groups => groups
                         .Skip(1)
                         .Where(g => g.All(entry => string.IsNullOrEmpty(entry.DeviceName)))
                         .SelectMany(g => g))
                     .ToArray();
 
+                // Find old drivers whose date is newer than the newest version's date.
+                this.driversWithNewerDate.Clear();
+
+                foreach (var groups in driverGroups)
+                {
+                    var newestDate = groups[0].Key.DriverDate;
+
+                    foreach (var entry in groups.Skip(1)
+                        .Where(g => g.Key.DriverDate > newestDate && g.All(e => string.IsNullOrEmpty(e.DeviceName)))
+                        .SelectMany(g => g))
+                    {
+                        this.driversWithNewerDate.Add(entry);
+                    }
+                }
+
                 if (oldDriversToSelect.Length == 0)
                 {
                     this.ShowStatus(Status.Warning, Language.Message_No_Old_Drivers_Found);
@@ -1093,14 +1117,22 @@ private async void ChooseDriverStoreToolStripMenuItem_Click(object sender, Event
 
         private void LstDriverStoreEntries_FormatCell(object sender, BrightIdeasSoftware.FormatCellEventArgs e)
         {
+            DriverStoreEntry entry = (DriverStoreEntry)e.Model;
+
             if (e.ColumnIndex == this.deviceNameColumn.Index)
             {
-                DriverStoreEntry entry = (DriverStoreEntry)e.Model;
                 if (entry.DevicePresent == false)
                 {
                     e.SubItem.ForeColor = Color.Gray;
                 }
             }
+            else if (e.ColumnIndex == this.driverDateColumn.Index)
+            {
+                if (this.driversWithNewerDate.Contains(entry))
+                {
+                    e.SubItem.ForeColor = Color.OrangeRed;
+                }
+            }
         }
 
         private void LstDriverStoreEntries_FormatRow(object sender, BrightIdeasSoftware.FormatRowEventArgs e)