Skip to content

Conversation

@stuartwesterman
Copy link
Contributor

@stuartwesterman stuartwesterman commented Dec 24, 2024

Description

This adds a rustup macports port.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.2
Xcode 16.2 / Command Line Tools x.y.z

Verification

Have you

@tobypeterson
Copy link
Contributor

tobypeterson commented Dec 28, 2024

Would this be used to update the rust that's installed by MacPorts? Seems a little redundant.

I see there's a note about uninstalling MacPorts rust, but that should probably be an explicit conflict. Still leaves me wondering if this port has any use.

@stuartwesterman
Copy link
Contributor Author

Would this be used to update the rust that's installed by MacPorts? Seems a little redundant.

I see there's a note about uninstalling MacPorts rust, but that should probably be an explicit conflict. Still leaves me wondering if this port has any use.

Yes, it should be an explicit conflict with the rust port. I'll add that to the Portfile.

Yes, rustup is very useful. It is particularly valuable for installing and managing multiple versions of Rust. One can easily switch between nightly, beta, and stable Rust toolchain versions. It also simplifies setting up cross-compilation toolchains for different targets.

@markemer
Copy link
Member

I do like the idea of having rustup - but I'd prefer to use it to install/update a non-macports rust. Which is already what I do on my machine under .cargo. The base being installable by macports would be nice though.

@stuartwesterman
Copy link
Contributor Author

I do like the idea of having rustup - but I'd prefer to use it to install/update a non-macports rust. Which is already what I do on my machine under .cargo. The base being installable by macports would be nice though.

Yes, that's what this is aiming to do. Macports installs rustup. Then rustup is used to manage a $HOME/.rustup/... suite of targets and tools.

@tobypeterson
Copy link
Contributor

tobypeterson commented Jan 15, 2025

Ok, so this won't actually conflict with rust from macports, it's just a different way to manage your rust install. I don't think I have any major objections here.

I wonder if the note should be reworded - no need to actually uninstall rust from macports if you're careful and/or set your PATH correctly.

Just a bit of thinking here, as nice as the "theory" of having a package manager do everything might be, these days it makes sense to defer a lot of things to other package tools. Package managers like MacPorts can provide rustup, which you can then use to get cargo and manage all things Rust. Likewise for uv and Python...

@stuartwesterman
Copy link
Contributor Author

Ok, so this won't actually conflict with rust from macports, it's just a different way to manage your rust install. I don't think I have any major objections here.

I wonder if the note should be reworded - no need to actually uninstall rust from macports if you're careful and/or set your PATH correctly.

Just a bit of thinking here, as nice as the "theory" of having a package manager do everything might be, these days it makes sense to defer a lot of things to other package tools. Package managers like MacPorts can provide rustup, which you can then use to get cargo and manage all things Rust. Likewise for uv and Python...

Yes! Correct! I removed the note about conflicting with macport's rust. That was incorrect.

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartwesterman there hasn't been any activity/progress on this PR for a while. Reading through the comments there doesn't appear to be clear objections against adding this to MacPorts. So I'd like to get this merged if you are able/willing to take care of a few final comments. Apologies for the delay...

@stuartwesterman
Copy link
Contributor Author

I've addressed the review comments. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants