Fix:ExecutionUnits JSON struct tags and EvaluateTx return type #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vardominator
approved these changes
Feb 5, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
ExecutionUnitsstruct has JSON field tags with incorrect capitalization. The JSON response received contains lowercase keys ('mem' and 'steps'), while the struct expects 'Mem' and 'Steps', causing a mismatch. As a result, theEvaluateTxfunction returns an empty slice. Additionally, replacing[]models.RedeemerEvaluationwithmodels.EvaluateTxResponsein theEvaluateTxfunction improves consistency and readability.Type of Change
fixing the following issue #53